1542921 - Turn on block autoplay in 67

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Nils Ohlmeier [:drno]]

Block autoplay appears to be off by default in everything except Nightly as per https://searchfox.org/mozilla-central/rev/8d78f219702286c873860f39f9ed78bad1a6d062/browser/app/profile/firefox.js#1491

As we have successfully rolled out the feature via Normandy in 66, we should turn the feature on in >= 67 to not have to rely on Normandy going forward any more.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1542921 - turn on block autoplay by default.

As we have successfully rolled out the feature via Normandy in 66, we should turn the feature on in >= 67 to not have to rely on Normandy going forward any more.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e1aac075975
turn on block autoplay by default. r=cpearce

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8e1aac075975

Comment 4

[Alastor Wu [:alwu]]

Comment on attachment 9056923 [details]
Bug 1542921 - turn on block autoplay by default.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: none
• User impact if declined: Will not be able to have block autoplay by default
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a pref-flip patch, it doesn't any functional change. In addition, we have enabled this feature on 66 via Normandy.
• String changes made/needed: none

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9056923 [details]
Bug 1542921 - turn on block autoplay by default.

Low risk, approved for 67 beta 10, thanks.

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/778c3da2f7ae

Comment 7

[Chris Mills [:cmills]]

I've added a release note to https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/67#APIs to document this. Let me know if this looks OK.

Comment 8

[Alastor Wu [:alwu]]

Hi, Chris,
I would prefer not to mention it, because actually we've enabled this feature on 66 via Normandy. What we do here now is just to ensure that no one will miss this feature on 67.
Thank you.

Comment 9

[Chris Mills [:cmills]]

(In reply to Alastor Wu [:alwu] from comment #8)

Hi, Chris,
I would prefer not to mention it, because actually we've enabled this feature on 66 via Normandy. What we do here now is just to ensure that no one will miss this feature on 67.
Thank you.

OK, makes sense to me; we do mention it in the Fx66 rel notes already.

I've removed it now.

Comment 10

[Kohei]

Updated the site compatibility note to mention this bug: https://www.fxsitecompat.com/en-CA/docs/2019/audible-media-s-autoplay-is-now-blocked-by-default/

Comment 11

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.