1542932 - Generate CustomElementConstructor from WebIDL callback definition

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[Karl Tomlinson (:karlt)]

CustomElementDefinition performs a copy conversion from a Function IDL callback to CustomElementConstructor to bypass class access protection on CallbackObject::CallSetup, to call JS::Construct(), and to provide non-void return values from the callback.

Let's instead generate CustomElementConstructor from WebIDL so that the interface definition can be more accurate, and so that other code involving constructor callbacks doesn't need to be separately hand-crafted.

https://github.com/heycam/webidl/issues/701 proposes a way that would indicate whether a callback is a construct or not, and so we can know whether a callback requires either Call() or Construct() methods.

Comment 1

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b2f4776a0ff9bf22149c10fd590a65b4fe56408

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1542932 part 1. Add support for callback constructors in the IDL parser. r=mccr8

Comment 3

[Karl Tomlinson (:karlt)]

Attachment: bug 1542932 Add code generation for callback constructors r?bzbarsky

TreatNonObjectAsNull is rejected in the parser because / so that there is no
need to implement the equivalent of CallCallback.getCallGuard().

Depends on D26864

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1542932 align CustomElementConstructor::Construct() parameters with WebIDL bindings conventions r?bzbarsky

Depends on D26865

Comment 5

[Karl Tomlinson (:karlt)]

Attachment: bug 1542932 Generate CustomElementConstructor from WebIDL callback definition r?bzbarsky

Depends on D26866

Comment 6

[Karl Tomlinson (:karlt)]

Attachment: Bug 1542932 Change define() parameter functionConstructor from Function to CustomElementConstructor r?bzbarsky

Depends on D26867

Comment 7

[Karl Tomlinson (:karlt)]

Attachment: Bug 1542932 Remove CustomElementConstructor copy r?bzbarsky

Depends on D26868

Comment 8

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a17ee5026a6c9ea71052dba73c0520abad949bd2

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f7069a44442
part 1. Add support for callback constructors in the IDL parser.  r=qdot
https://hg.mozilla.org/integration/autoland/rev/9c837ead0cab
Add code generation for callback constructors r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/87dfe897f8aa
align CustomElementConstructor::Construct() parameters with WebIDL bindings conventions r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/a3305716fa2e
Generate CustomElementConstructor from WebIDL callback definition r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/60e641a02435
Change define() parameter functionConstructor from Function to CustomElementConstructor r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/6d1c102cccd2
Remove CustomElementConstructor copy r=bzbarsky

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7f7069a44442
https://hg.mozilla.org/mozilla-central/rev/9c837ead0cab
https://hg.mozilla.org/mozilla-central/rev/87dfe897f8aa
https://hg.mozilla.org/mozilla-central/rev/a3305716fa2e
https://hg.mozilla.org/mozilla-central/rev/60e641a02435
https://hg.mozilla.org/mozilla-central/rev/6d1c102cccd2