Closed Bug 1543013 Opened 7 years ago Closed 7 years ago

Make accessible use mozilla::PresShell directly rather than via nsIPresShell

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(2 files)

No description provided.

This patch makes accessible module use mozilla::PresShell directly rather
than via nsIPresShell. Additionally, marks some nsCoreUtils methods as
MOZ_CAN_RUN_SCRIPT to guarantee lifetime of their arguments.

Note that in DocAccessible and its sub classes, PresShell needs to be
mozilla::PresShell for avoiding conflict with DocAccessible::PresShell().

This patch marks some methods of nsCoreUtils which are found at writing the
following patches, as MOZ_CAN_RUN_SCRIPT.

Due to bug 1543294, some of them are marked as MOZ_CAN_RUN_SCRIPT_BOUNDARY
because MOZ_CAN_RUN_SCRIPT requires to change base class, but that's
other licenses header or used in our code too many places.

Attachment #9056819 - Attachment description: Bug 1543013 - Make accessible use mozilla::PresShell directly rather than via nsIPresShell → Bug 1543013 - part 2: Make accessible use mozilla::PresShell directly rather than via nsIPresShell
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/7f7f40328e31 part 1: Mark some methods of nsCoreUtils as MOZ_CAN_RUN_SCRIPT r=Jamie https://hg.mozilla.org/integration/autoland/rev/5e25c3854986 part 2: Make accessible use mozilla::PresShell directly rather than via nsIPresShell r=Jamie
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: