1543022 - Content Blocking icon on the URL bar appears on internal about: pages

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Itiel]

This is a regression from bug 1522919.

STR:

1. Fresh profile, latest Nightly, Windows 10
2. Open in 3 tabs: youtube.com, facebook.com, about:performance (after opening about:performance don't switch to the Facebook tab)
3. Switch to the YouTube tab (see that there's no Content Blocking icon on the URL bar in this tab) and back to the about:performance tab -- the only icon on the URL bar for that tab is the (i) icon -- expected behaviour
4. Switch to the Facebook tab (see that the Content Blocking icon is present on the URL bar in this tab) and back to the about:performance tab -- the Content Blocking icon from the Facebook tab is carried over to the about:performance tab -- wrong behaviour

Comment 1

[Johann Hofmann [:johannh]]

[Tracking Requested - why for this release]:
Confusing security/privacy UI for about: pages

Thank you for finding this! Erica, can you please take a look? Thanks!

Comment 2

[Erica Wright [:ewright]]

Yes, this is reproducible on mac too, I'll look into it.

Comment 3

[Erica Wright [:ewright]]

Attachment: Bug 1543022 - do not show content blocking icon on about: pages when location change isSimulated.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d245ef38503c
do not show content blocking icon on about: pages when location change isSimulated. r=johannh

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d245ef38503c

Comment 6

[Pascal Chevrel:pascalc]

Erica, could you request the uplift to beta please? Thanks

Comment 7

[Itiel]

Fixed on latest Nightly.

Comment 8

[Erica Wright [:ewright]]

Comment on attachment 9057679 [details]
Bug 1543022 - do not show content blocking icon on about: pages when location change isSimulated.

Beta/Release Uplift Approval Request

• User impact if declined: about: pages sometimes incorrectly show the content blocking shield
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): UI change. Restoring some code back to how it was originally.
• String changes made/needed:

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9057679 [details]
Bug 1543022 - do not show content blocking icon on about: pages when location change isSimulated.

Fix for a P1 tracked bug with tests, uplift approved for 67 beta 14, thanks.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The bug which regressed this (bug 1522919) never landed on beta (= Gecko 67).

Comment 11

[Pascal Chevrel:pascalc]

Comment on attachment 9057679 [details]
Bug 1543022 - do not show content blocking icon on about: pages when location change isSimulated.

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #10)

The bug which regressed this (bug 1522919) never landed on beta (= Gecko 67).

Uplift not needed then, I adjusted the flag.

Comment 12

[Ciprian Georgiu, Desktop QA]

Reproduced this bug with the steps described in comment 0, using an affected Nightly build from 2019-04-09.

I can also confirm this fix on Beta 68.0b6 (20190529145824) running Windows 10 x64, macOS 10.14 and Ubuntu 18.04 x64.