1543122 - Add the Picture-in-Picture toggle to the <video controls/> UAWidget binding

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

This will require the following:

1. The ability for the UAWidget to know whether or not the preference to show the toggle is enabled

2. The ability for the UAWidget to launch Picture-in-Picture when the user clicks on that toggle (likely via a WebIDL method on HTMLVideoElement, since the events dispatched directly from the UAWidget scope don't seem to be trusted)

3. Adjust the PictureInPictureToggleChild to not show the AnonymousContent toggle or flyout toggle over top of <video controls/> elements

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1543122 - Allow passing a static list of preference values to UAWidgets upon construction. r?bgrins

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1543122 - Add a preference for controlling whether or not we display a toggle for Picture-in-Picture on <video> elements. r?jaws

Depends on D26775

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1543122 - Add a privileged UAWidget-accessible WebIDL API for triggering Picture-in-Picture. r?jya,ehsan

Depends on D26776

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1543122 - Add the simple Picture-in-Picture toggle to the <video controls/> binding, still preffed off by default. r?jaws

This also stops the PictureInPictureToggleChild from tracking videos with controls for now.

Depends on D26777

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aab68db4131b
Allow passing a static list of preference values to UAWidgets upon construction. r=bgrins
https://hg.mozilla.org/integration/autoland/rev/3fce0b7586c1
Add a preference for controlling whether or not we display a toggle for Picture-in-Picture on <video> elements. r=jaws
https://hg.mozilla.org/integration/autoland/rev/1645d577016c
Add a privileged UAWidget-accessible WebIDL API for triggering Picture-in-Picture. r=jya,Ehsan
https://hg.mozilla.org/integration/autoland/rev/20092bcebe6a
Add the simple Picture-in-Picture toggle to the <video controls/> binding, still preffed off by default. r=jaws

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3619626a7662
Allow passing a static list of preference values to UAWidgets upon construction. r=bgrins
https://hg.mozilla.org/integration/autoland/rev/22f9a15468c4
Add a preference for controlling whether or not we display a toggle for Picture-in-Picture on <video> elements. r=jaws
https://hg.mozilla.org/integration/autoland/rev/fbb2191cafbe
Add a privileged UAWidget-accessible WebIDL API for triggering Picture-in-Picture. r=jya,Ehsan
https://hg.mozilla.org/integration/autoland/rev/bd9017823675
Add the simple Picture-in-Picture toggle to the <video controls/> binding, still preffed off by default. r=jaws

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: one-liner-fix.diff

Bah, this will teach me to "clean up a patch" after pushing to try. :( (This is to fix the TV failure on the most recent push).

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3619626a7662
https://hg.mozilla.org/mozilla-central/rev/22f9a15468c4
https://hg.mozilla.org/mozilla-central/rev/fbb2191cafbe
https://hg.mozilla.org/mozilla-central/rev/bd9017823675

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3619626a7662
https://hg.mozilla.org/mozilla-central/rev/22f9a15468c4
https://hg.mozilla.org/mozilla-central/rev/fbb2191cafbe
https://hg.mozilla.org/mozilla-central/rev/bd9017823675