1543139 - Remove type="text/css" on <style> and <link> elements, and <xml-stylesheet> PIs in tree

Status: NEW

(Core :: CSS Parsing and Computation, task, P3)

Description

[Brian Grinstead [:bgrins]]

+++ This bug was initially created as a clone of Bug #1542877 +++

This is another thing we could do to tighten up test boilerplate. See https://groups.google.com/d/msg/mozilla.dev.platform/2cDuT_sNZ-o/V4w-zBhCCQAJ.

Comment 1

[Brian Grinstead [:bgrins]]

Cam, to confirm: this would only apply to <style> tags and not <?xml-stylesheet> or <link rel="stylesheet">, correct?

Comment 2

[Emilio Cobos Álvarez [:emilio]]

It should also apply to <link rel="stylesheet">. Not 100% sure about xml-stylesheets, but probably too.

Comment 3

[Boris Zbarsky [:bzbarsky]]

As Emilio says, <link> defaults to type="text/css" if rel="stylesheet".

xml-stylesheet PIs have the same behavior. See https://searchfox.org/mozilla-central/source/dom/xml/XMLStylesheetProcessingInstruction.cpp#119 where an empty type is treated the same as "text/css".

Or for an experimental testcase:

data:text/xml,<?xml-stylesheet href="data:text/css,* { color: red }"?><root>text</root>

Comment 4

[Brian Grinstead [:bgrins]]

Thanks! Updating the title to reflect this.

Comment 5

[Martin Thomson [:mt:]]

If you are looking for a linter, this outputs "true" if there is a type attribute on the wrong thing.

xmllint --html --xpath '//link[@rel="stylesheet"]/@type or //style/@type' index.html 2>/dev/null

It shouldn't be too hard to add a selector for the PI to that.

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: Bug 1543139 - Remove [type="text/css"] on one-liner XML PIs loading "chrome://global/skin"