1543143 - about:license has bogus [dir=rtl] selector

Status: RESOLVED FIXED

(Toolkit :: Themes, task, P5)

Description

[:Gijs (he/him)]

There's some confusing things going on here - bug 1361695 added a license-header, but the CSS uses rights-header, in addition to a body[dir=rtl] check that looks to me like it'll never match because nothing would set that attribute (that I can see).

Comment 1

[Itiel]

AFAICT about:license is not localizable, so I see no point in having any dir selector..

Comment 2

[:Gijs (he/him)]

(In reply to Itiel from comment #1)

AFAICT about:license is not localizable, so I see no point in having any dir selector..

Dão, should we just make this a good first bug to remove this rule?

Comment 3

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #2)

(In reply to Itiel from comment #1)

AFAICT about:license is not localizable, so I see no point in having any dir selector..

Dão, should we just make this a good first bug to remove this rule?

Sure, let's remove this rule:

https://searchfox.org/mozilla-central/rev/dd7e27f4a805e4115d0dbee70e1220b23b23c567/toolkit/themes/shared/aboutLicense.css#12-15

Comment 4

[Nidhi Kumari]

Attachment: Bug 1543143 - deleted bogus selector in aboutLicense.css

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3514a3988f25
deleted bogus selector in aboutLicense.css r=Gijs

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3514a3988f25