Closed Bug 1543143 Opened 5 months ago Closed 5 months ago

about:license has bogus [dir=rtl] selector

Categories

(Toolkit :: Themes, task, P5)

67 Branch
task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Gijs, Assigned: nimbus2020b, Mentored)

References

(Regression)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

There's some confusing things going on here - bug 1361695 added a license-header, but the CSS uses rights-header, in addition to a body[dir=rtl] check that looks to me like it'll never match because nothing would set that attribute (that I can see).

AFAICT about:license is not localizable, so I see no point in having any dir selector..

(In reply to Itiel from comment #1)

AFAICT about:license is not localizable, so I see no point in having any dir selector..

Dão, should we just make this a good first bug to remove this rule?

Flags: needinfo?(dao+bmo)
Priority: -- → P5

(In reply to :Gijs (he/him) from comment #2)

(In reply to Itiel from comment #1)

AFAICT about:license is not localizable, so I see no point in having any dir selector..

Dão, should we just make this a good first bug to remove this rule?

Sure, let's remove this rule:

https://searchfox.org/mozilla-central/rev/dd7e27f4a805e4115d0dbee70e1220b23b23c567/toolkit/themes/shared/aboutLicense.css#12-15

Mentor: dao+bmo
Type: defect → task
Component: General → Themes
Flags: needinfo?(dao+bmo)
Keywords: good-first-bug
Product: Firefox → Toolkit
Attachment #9057460 - Attachment description: Bug 1543143 - deleted bogus selector → Bug 1543143 - deleted bogus selector in aboutLicense.css
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3514a3988f25
deleted bogus selector in aboutLicense.css r=Gijs
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → nimbus2020b
You need to log in before you can comment on or make changes to this bug.