15435 - Bookmarks parser adding spaces to long bookmarks

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Suresh Duddi (gone)]

Here is my query for my M11 bugs for our group. A space seems to have
 gotten added. Look at "&emailassigned_t o1=1&email2" The space
 inbetween the "t" and "o1" is the problem. This was ok the first time
 it got migrated. So I suspect this happened in our routine to write
 bookmarks out.
 <DT><A
HREF="http://bugzilla.mozilla.org/buglist.cgi?target_milestone=M11&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&email1=%5E%28dp%7Cneeti%7Crjc%7Cwaterson%7Cmorse%7Cpnunn%7Cspence%7Cebina%29&emailtype1=regexp&emailassigned_t
o1=1&email2=&emailtype2=substring&emailreporter2=1&changedin=&short_desc=&short_desc_type=substr&long_desc=&long_desc_type=substr&bug_file_loc=&bug_file_loc_type=substr&status_whiteboard=&status_whiteboard_type=substr&newqueryname=&form_name=query&order=a
ssign.login_name%2C%20assign.login_name%2C%20bugs.priority%2C%20bugs.bug_severity"
ADD_DATE="926790687" LAST_VISIT="939002554" LAST_MODIFIED="926790661">M11</A>

The right bookmark is:
<DT><A
HREF="http://bugzilla.mozilla.org/buglist.cgi?target_milestone=M11&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&email1=%5E%28dp%7Cneeti%7Crjc%7Cwaterson%7Cmorse%7Cpnunn%7Cspence%7Cebina%29&emailtype1=regexp&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&changedin=&short_desc=&short_desc_type=substr&long_desc=&long_desc_type=substr&bug_file_loc=&bug_file_loc_type=substr&status_whiteboard=&status_whiteboard_type=substr&newqueryname=&form_name=query&order=assign.login_name%2C%20assign.login_name%2C%20bugs.priority%2C%20bugs.bug_severity"
ADD_DATE="926790687" LAST_VISIT="938817236" LAST_MODIFIED="926790661">M11</A>

The above happened to every bookmark like this... I have M10, M11, M12
bookmarks.

Comment 1

[Robert John Churchill]

Its a problem with reading in bookmarks on a long line that causes buffer

overflow (byte # 256 currently, as our buffers are 256 bytes) where the UTF-8

conversion takes the trailing 0x00 byte and changes it to a space.



I have a fix. DP, want to review it for me?

Comment 2

[leger]

Adding verifyme keyword.

Comment 3

[leger]

dp, so what is the specific testcase to verify?

Comment 4

[Claudius Gayle]

so robert, is it sufficient to bookmark "the right bookmark" dp lists in 4.x and then migrate the profile containing that bookmark 
to seamonkey and then visually inspect that the url contians no spaces in the properties dialog?

Comment 5

[Robert John Churchill]

Yeah, think so.

Comment 6

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]