1543531 - Port |Bug 1433685 - Remove nsGConfService|

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

https://searchfox.org/comm-central/search?q=nsIGConfService&case=false&regexp=false&path=

Something for the Linux heads. Maybe just remove the stuff since much of it has if (gconf), so it will work without it, mostly.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dda5855e718c
Port bug 1433685 - Remove nsGConfService; rs=bustage-fix

Comment 2

[Geoff Lankow (:darktrojan) [PTO, back 9 Feb]]

Attachment: 1543531-remove-gconf-service.diff

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9057408 [details] [diff] [review]
1543531-remove-gconf-service.diff

Straight removal, thanks. Bug 1433685 comment #0 says: gconf, being a long deprecated GNOME 2 component, should not be dependend upon. So it's most likely OK to remove it completely.

Comment 4

[:aceman]

OK, we can remove this, but we need to see if we have the replacement Gsettings backend used. In the patch I only see gIOService being used in addition. Is that the alternative to GConf?
Also, Seamonkey is probably broken too after the m-c patch.

Comment 5

[Ian Neal]

(In reply to :aceman from comment #4)

OK, we can remove this, but we need to see if we have the replacement Gsettings backend used. In the patch I only see gIOService being used in addition. Is that the alternative to GConf?
Also, Seamonkey is probably broken too after the m-c patch.

Yes, we have a patch in progress at the moment.

Comment 6

[:aceman]

Comment on attachment 9057408 [details] [diff] [review]
1543531-remove-gconf-service.diff

Review of attachment 9057408 [details] [diff] [review]:
-----------------------------------------------------------------

I tested this on Linux (not GNOME but KDE) and in the System integration dialog I could set Daily as default for Newsgroups and this setting did stick across restarts of TB. So it seems there is still an OS backend that we call and it stores the setting.

Comment 7

[Intermittent Failures Robot]

4 failures in 3025 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 4

Platform breakdown:

• linux32: 2
• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1543531&startday=2019-04-08&endday=2019-04-14&tree=all