1543564 - Get rid of pointless AsInner/AsOuter methods on windows

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

They return the same type as they're called on, so there's not much point apart from maybe a confusing cast to a superclass to avoid ambiguity, which we can do better, I expect.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1543564 part 1. Get rid of pointless nsPIDOMWindowOuter::AsOuter() methods. r=farre

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1543564 part 2. Get rid of pointless nsPIDOMWindowInner::AsInner methods. r=farre

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1543564 part 3. Get rid of pointless nsPIDOMWindowOuter::GetOuterWindow method. r=farre

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1b827eab86f
part 1.  Get rid of pointless nsPIDOMWindowOuter::AsOuter() methods.  r=farre
https://hg.mozilla.org/integration/autoland/rev/27a7ba728216
part 2.  Get rid of pointless nsPIDOMWindowInner::AsInner methods.  r=farre
https://hg.mozilla.org/integration/autoland/rev/abafb9533234
part 3.  Get rid of pointless nsPIDOMWindowOuter::GetOuterWindow method.  r=farre

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a1b827eab86f
https://hg.mozilla.org/mozilla-central/rev/27a7ba728216
https://hg.mozilla.org/mozilla-central/rev/abafb9533234