Closed Bug 1543564 Opened 1 year ago Closed 1 year ago

Get rid of pointless AsInner/AsOuter methods on windows

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(3 files)

Bug 1543564 part 1. Get rid of pointless nsPIDOMWindowOuter::AsOuter() methods. r=farre
47 bytes, text/x-phabricator-request
Details | Review
Bug 1543564 part 2. Get rid of pointless nsPIDOMWindowInner::AsInner methods. r=farre
47 bytes, text/x-phabricator-request
Details | Review
Bug 1543564 part 3. Get rid of pointless nsPIDOMWindowOuter::GetOuterWindow method. r=farre
47 bytes, text/x-phabricator-request
Details | Review

They return the same type as they're called on, so there's not much point apart from maybe a confusing cast to a superclass to avoid ambiguity, which we can do better, I expect.

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1b827eab86f
part 1.  Get rid of pointless nsPIDOMWindowOuter::AsOuter() methods.  r=farre
https://hg.mozilla.org/integration/autoland/rev/27a7ba728216
part 2.  Get rid of pointless nsPIDOMWindowInner::AsInner methods.  r=farre
https://hg.mozilla.org/integration/autoland/rev/abafb9533234
part 3.  Get rid of pointless nsPIDOMWindowOuter::GetOuterWindow method.  r=farre
You need to log in before you can comment on or make changes to this bug.