1543617 - Disallow place: urls in text flavors

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Marco Bonardo [:mak]]

containers should only be transferable through place flavors, there's no point in copying over a place: url through text flavors.
Basically, we can make unwrapNodes skip place: uris for non-place flavors.

Comment 1

[Marco Bonardo [:mak]]

Attachment: Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e5250ccb4fe
Disallow place: urls in text flavors. r=Standard8

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3e5250ccb4fe

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 9057470 [details]
Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: None
• User impact if declined: See bug 1543191
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See bug 1543191
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch
• String changes made/needed: none

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: See bug 1543191
• User impact if declined: See bug 1543191
• Fix Landed on Version: 68
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch
• String or UUID changes made by this patch: none

Comment 5

[Pascal Chevrel:pascalc]

Let's get it verified on Nightly before uplifting.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

STR are in bug 1543191.

Comment 7

[Brindusa Tot, Desktop QA]

Marco, could you please give me access to bug 1543191 in order to verify this bug? If access to the bug is not possible, can you please provide some steps for manual verification in this bug?

Comment 8

[Marco Bonardo [:mak]]

done

Comment 9

[Gyula Palko[:gpalko]]

Verified on Nightly 68(20190417093858), using the attachment from Bug 1543191. The place: url cannot be dropped to Bookmarks Toolbar/Sidebar.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9057470 [details]
Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Low risk, verified by QA on Nightly, uplift approved for 67 beta 12, thanks.

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/15baf86bf317

Comment 12

[Gyula Palko[:gpalko]]

Verified on Beta 67(20190418160535), using the attachment from Bug 1543191. The place: url cannot be dropped to Bookmarks Toolbar/Sidebar.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9057470 [details]
Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Fix for bookmarks issue, verified in nightly; OK for uplift for ESR 60.7.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/abdb274a04d1