Closed Bug 1543617 Opened 3 years ago Closed 3 years ago

Disallow place: urls in text flavors

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox-esr60 67+ fixed
firefox66 --- wontfix
firefox67 --- verified
firefox68 --- verified

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

containers should only be transferable through place flavors, there's no point in copying over a place: url through text flavors.
Basically, we can make unwrapNodes skip place: uris for non-place flavors.

Summary: Disallow place: urls in url or unicode flavors → Disallow place: urls in text flavors
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/3e5250ccb4fe
Disallow place: urls in text flavors. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Comment on attachment 9057470 [details]
Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: See bug 1543191
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See bug 1543191
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch
  • String changes made/needed: none

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: See bug 1543191
  • User impact if declined: See bug 1543191
  • Fix Landed on Version: 68
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch
  • String or UUID changes made by this patch: none
Attachment #9057470 - Flags: approval-mozilla-esr60?
Attachment #9057470 - Flags: approval-mozilla-beta?
Flags: qe-verify?

Let's get it verified on Nightly before uplifting.

Flags: qe-verify? → qe-verify+
QA Whiteboard: [qa-triaged]

Marco, could you please give me access to bug 1543191 in order to verify this bug? If access to the bug is not possible, can you please provide some steps for manual verification in this bug?

Flags: needinfo?(mak77)

done

Flags: needinfo?(mak77)

Verified on Nightly 68(20190417093858), using the attachment from Bug 1543191. The place: url cannot be dropped to Bookmarks Toolbar/Sidebar.

Flags: qe-verify+

Comment on attachment 9057470 [details]
Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Low risk, verified by QA on Nightly, uplift approved for 67 beta 12, thanks.

Attachment #9057470 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified on Beta 67(20190418160535), using the attachment from Bug 1543191. The place: url cannot be dropped to Bookmarks Toolbar/Sidebar.

QA Whiteboard: [qa-triaged]

Comment on attachment 9057470 [details]
Bug 1543617 - Disallow place: urls in text flavors. r=Standard8

Fix for bookmarks issue, verified in nightly; OK for uplift for ESR 60.7.

Attachment #9057470 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.