Closed Bug 1543679 Opened 5 months ago Closed 5 months ago

Ensure all files under remote/ are referenced, or removed

Categories

(Remote Protocol :: Agent, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ato, Assigned: ato)

References

Details

Attachments

(1 file)

There are three files under remote/ which are never referenced,
causing browser/base/content/test/static/browser_all_files_referenced.js
to fail:

[task 2019-04-11T12:20:58.872Z] 12:20:58     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 3, expected 0
[task 2019-04-11T12:20:58.873Z] 12:20:58     INFO - Stack trace:
[task 2019-04-11T12:20:58.874Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:test_is:1325
[task 2019-04-11T12:20:58.874Z] 12:20:58     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:790
[task 2019-04-11T12:20:58.875Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-11T12:20:58.875Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-11T12:20:58.876Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-11T12:20:58.876Z] 12:20:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-11T12:20:58.878Z] 12:20:58     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-11T12:20:58.878Z] 12:20:58     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: chrome://remote/content/server/Packet.jsm referenced from chrome://remote/content/server/Transport.jsm - 
[task 2019-04-11T12:20:58.879Z] 12:20:58     INFO - Stack trace:
[task 2019-04-11T12:20:58.879Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
[task 2019-04-11T12:20:58.879Z] 12:20:58     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:800
[task 2019-04-11T12:20:58.880Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-11T12:20:58.880Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-11T12:20:58.880Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-11T12:20:58.880Z] 12:20:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-11T12:20:58.883Z] 12:20:58     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-11T12:20:58.884Z] 12:20:58     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://remote/content/server/Socket.jsm - 
[task 2019-04-11T12:20:58.885Z] 12:20:58     INFO - Stack trace:
[task 2019-04-11T12:20:58.886Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
[task 2019-04-11T12:20:58.887Z] 12:20:58     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:794
[task 2019-04-11T12:20:58.887Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
[task 2019-04-11T12:20:58.888Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
[task 2019-04-11T12:20:58.889Z] 12:20:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
[task 2019-04-11T12:20:58.890Z] 12:20:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-04-11T12:20:58.891Z] 12:20:58     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-04-11T12:20:58.892Z] 12:20:58     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | file only referenced from unreferenced files: chrome://remote/content/server/Transport.jsm referenced from chrome://remote/content/server/Socket.jsm - 
Assignee: nobody → ato
Blocks: 1533831
Status: NEW → ASSIGNED
Priority: -- → P1

These files became redundant after we started serving WebSocket
connections from the HTTPD.

This fixes the test
browser/base/content/test/static/browser_all_files_referenced.js,
which checks for unreferenced JSMs.

Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04185cfeb1ae
remote: remove unused server files; r=ochameau,yulia
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.