Closed Bug 1543711 Opened 6 years ago Closed 6 years ago

Incorrect function call to getDisplayNameForFile should be getFileDisplayName

Categories

(SeaMonkey :: Download & File Handling, defect)

Product:
SeaMonkey
Component:
Download & File Handling
Version:
SeaMonkey 2.53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.53 affected, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.65
Tracking Flags:
Tracking Status
seamonkey2.53 --- affected
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Regression)

Details

Attachments

(1 file, 2 obsolete files)

Unbitrotted version
1.31 KB, patch
frg
: review+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Bug 796994 made use getDisplayNameForFile but the correct function name is GetFileDisplayName.

Attached patch Change the caller (obsolete) — — Splinter Review

Also needed for 2.53

Attachment #9057536 - Flags: review?(frgrahl)
Attachment #9057536 - Flags: approval-comm-esr60?
Attached patch Change the caller (obsolete) — — Splinter Review

Hopefully with correct header now

Attachment #9057536 - Attachment is obsolete: true
Attachment #9057536 - Flags: review?(frgrahl)
Attachment #9057536 - Flags: approval-comm-esr60?
Attachment #9057562 - Flags: review?(frgrahl)
Attachment #9057562 - Flags: approval-comm-esr60?

Must update before creating a patch!

Attachment #9057562 - Attachment is obsolete: true
Attachment #9057562 - Flags: review?(frgrahl)
Attachment #9057562 - Flags: approval-comm-esr60?
Attachment #9057571 - Flags: review?(frgrahl)
Attachment #9057571 - Flags: approval-comm-esr60?
Comment on attachment 9057571 [details] [diff] [review] Unbitrotted version And I thought I tested all callers. Seems not. Thanks.
Attachment #9057571 - Flags: review?(frgrahl)
Attachment #9057571 - Flags: review+
Attachment #9057571 - Flags: approval-comm-esr60?
Attachment #9057571 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f386d6792ead
Incorrect function call to getDisplayNameForFile should be getFileDisplayName r=frg

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: