Incorrect function call to getDisplayNameForFile should be getFileDisplayName

RESOLVED FIXED in seamonkey2.65

Status

defect
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

(Regression)

SeaMonkey 2.53 Branch
seamonkey2.65

SeaMonkey Tracking Flags

(seamonkey2.53 affected, seamonkey2.57esr fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Bug 796994 made use getDisplayNameForFile but the correct function name is GetFileDisplayName.

Posted patch Change the caller (obsolete) — Splinter Review

Also needed for 2.53

Attachment #9057536 - Flags: review?(frgrahl)
Attachment #9057536 - Flags: approval-comm-esr60?
Posted patch Change the caller (obsolete) — Splinter Review

Hopefully with correct header now

Attachment #9057536 - Attachment is obsolete: true
Attachment #9057536 - Flags: review?(frgrahl)
Attachment #9057536 - Flags: approval-comm-esr60?
Attachment #9057562 - Flags: review?(frgrahl)
Attachment #9057562 - Flags: approval-comm-esr60?

Must update before creating a patch!

Attachment #9057562 - Attachment is obsolete: true
Attachment #9057562 - Flags: review?(frgrahl)
Attachment #9057562 - Flags: approval-comm-esr60?
Attachment #9057571 - Flags: review?(frgrahl)
Attachment #9057571 - Flags: approval-comm-esr60?
Comment on attachment 9057571 [details] [diff] [review]
Unbitrotted version

And I thought I tested all callers. Seems not. Thanks.
Attachment #9057571 - Flags: review?(frgrahl)
Attachment #9057571 - Flags: review+
Attachment #9057571 - Flags: approval-comm-esr60?
Attachment #9057571 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/f386d6792ead
Incorrect function call to getDisplayNameForFile should be getFileDisplayName r=frg

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.