1543715 - Some tracking still blocked even though domains are in manifest.json

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect)

Description

[Mike Kaply [:mkaply]]

We are continuing to investigate working around tracking protection in the Amazon Assistant addon.

Adding the proper domains to manifest.json is mostly working, but we still see a couple block message.

To recreate:

Download the Amazon Assistant and unzip into a directory.

https://addons.mozilla.org/en-US/firefox/addon/amazon-browser-bar/
Install via about:debugging, go to settings and switch the language to German.
Verify it doesn't work when you open the dropdown via the toolbar button.

Close Firefox.
Edit manifest.json and add the following to permissions:

"https://www.amazon.fr/",
"https://www.amazon.de/",
"https://horizonte.browserapps.amazon.de/",
"https://fls-eu.amazon.de/",
"https://identity.browserapps.amazon.de/",
"https://dossier.browserapps.amazon.de/",
"https://storage.browserapps.amazon.de/",
"https://reporter.browserapps.amazon.de/",
"https://feed.browserapps.amazon.de/"

Restart Firefox and load the Amazon assistant via about:debugging.
Verify that the dropdown now works.

Go to the javascript console and notice that access to a URL on one of the approved domains - "https://fls-eu.amazon.de/" is still being blocked in extension.html.

If you remove the lines in manifest.json, Lots more stuff is blocked in extension.html, so it's not an issue with blocking in extension.html in general.

Comment 1

[David Durst [:ddurst]]

NI Ehsan to look at this, as a followup from bug 1509112.

Comment 2

[(no longer active)]

(In reply to Mike Kaply [:mkaply] from comment #0)

We are continuing to investigate working around tracking protection in the Amazon Assistant addon.

Adding the proper domains to manifest.json is mostly working, but we still see a couple block message.

To recreate:

Download the Amazon Assistant and unzip into a directory.

https://addons.mozilla.org/en-US/firefox/addon/amazon-browser-bar/
Install via about:debugging, go to settings and switch the language to German.
Verify it doesn't work when you open the dropdown via the toolbar button.

Close Firefox.
Edit manifest.json and add the following to permissions:

"https://www.amazon.fr/",
"https://www.amazon.de/",
"https://horizonte.browserapps.amazon.de/",
"https://fls-eu.amazon.de/",
"https://identity.browserapps.amazon.de/",
"https://dossier.browserapps.amazon.de/",
"https://storage.browserapps.amazon.de/",
"https://reporter.browserapps.amazon.de/",
"https://feed.browserapps.amazon.de/"

Restart Firefox and load the Amazon assistant via about:debugging.
Verify that the dropdown now works.

Hmm, so there is no problem?

Go to the javascript console and notice that access to a URL on one of the approved domains - "https://fls-eu.amazon.de/" is still being blocked in extension.html.

Out of curiosity what exact message did you get on the JS console?

If you remove the lines in manifest.json, Lots more stuff is blocked in extension.html, so it's not an issue with blocking in extension.html in general.

OK, that's expected, removing those lines effectively takes us back to https://bugzilla.mozilla.org/show_bug.cgi?id=1509112#c42. So no surprise there.

But more importantly, what's the thing that breaks as part of this bug? Since the other bug was filed for the French version of the Amazon Assistant I'm not quite sure what I'm supposed to test here and how...

Comment 3

[Mike Kaply [:mkaply]]

The latest version of Amazon Assistant isn't showing this error, so I'm going to say "Works for me"

Comment 4

[(no longer active)]

Great, thanks, let me know if something breaks again!