1543782 - After deleting a value in Rules, show autocomplete popup as long as the user has the field focused

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Victoria Wang [:victoria]]

Attachment: image.png

When deleting a CSS value, the Rules pane should have the same behavior as when the user first enters a value field: The user should see a dropdown with the possible keyword values.

This will be especially useful for the many flexbox values which are tough to remember. (Reported by :birtles)

Comment 1

[Martin Balfanz [:mbalfanz]]

I think it would be good to introduce a keyboard shortcut to always bring back auto-complete if it's lost. VSCode uses for example ctrl+space by default to achieve this.

Comment 2

[Brad Werth [:bradwerth]]

Good idea! In the interim, pressing the down key on the keyboard will re-trigger the autocomplete.

Comment 3

[Patrick Brosset <:pbro>]

I believe this should be a dt-q bug as this was reported as frustrating by people many times.
Myself, after using the rule-view for many years, I didn't even know that pressing the down key would work, so I have developed the habit of going back to the name (shift-tab), and then back to the value again (tab). This is cumbersome, I shouldn't have to do this.
This is also a chrome-parity problem. In Chrome devtools, when you delete the value, the list re-appears automatically.
I also tested ctrl+space and it indeed works in Chrome too, so we should add this too.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1543782: Show the suggestions in case that the css value becomes empty. r?pbro

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1543782: Show the suggestions when user presses ctrl+space. r?pbro

Depends on D43719

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1543782: Show the suggestions in case that the css value becomes empty for new rule inspector. r?pbro

Depends on D43720

Comment 7

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1543782: Add tests in case of empty. r?pbro

Depends on D43721

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1543782: Add test for the shortcut key which shows the suggest completion popup. r?pbro

Depends on D43722

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb477711fa64
Show the suggestions in case that the css value becomes empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/822638e9789a
Show the suggestions when user presses ctrl+space. r=pbro
https://hg.mozilla.org/integration/autoland/rev/703a2947c350
Show the suggestions in case that the css value becomes empty for new rule inspector. r=pbro
https://hg.mozilla.org/integration/autoland/rev/2081fd72fd28
Add tests in case of empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/d7b6b036d777
Add test for the shortcut key which shows the suggest completion popup. r=pbro

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/cb477711fa64
https://hg.mozilla.org/mozilla-central/rev/822638e9789a
https://hg.mozilla.org/mozilla-central/rev/703a2947c350
https://hg.mozilla.org/mozilla-central/rev/2081fd72fd28
https://hg.mozilla.org/mozilla-central/rev/d7b6b036d777

Comment 11

[Cristian Brindusan [:cbrindusan]]

Backed out 5 changesets (Bug 1543782) for devtools failures on browser_rules_completion-on-empty.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/c5ad764d28355ec966faaed00e94076fd39a9a4a

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d7b6b036d777c0d3290f5d923a987f2cefebff73

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264216520&repo=autoland&lineNumber=4666

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/c5ad764d2835

Comment 13

[Daisuke Akatsuka (:daisuke)]

try again: https://treeherder.mozilla.org/#/jobs?repo=try&revision=280c55fc10b5895e2e708163dbb49d80f89fefbb

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/158098f49ec2
Show the suggestions in case that the css value becomes empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/541172579196
Show the suggestions when user presses ctrl+space. r=pbro
https://hg.mozilla.org/integration/autoland/rev/ed8158ce9770
Show the suggestions in case that the css value becomes empty for new rule inspector. r=pbro
https://hg.mozilla.org/integration/autoland/rev/e1ba24ca37a4
Add tests in case of empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/90f33e9e1c48
Add test for the shortcut key which shows the suggest completion popup. r=pbro

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/158098f49ec2
https://hg.mozilla.org/mozilla-central/rev/541172579196
https://hg.mozilla.org/mozilla-central/rev/ed8158ce9770
https://hg.mozilla.org/mozilla-central/rev/e1ba24ca37a4
https://hg.mozilla.org/mozilla-central/rev/90f33e9e1c48