Closed Bug 1543782 Opened 6 months ago Closed 2 months ago

After deleting a value in Rules, show autocomplete popup as long as the user has the field focused

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: victoria, Assigned: daisuke)

References

Details

(Keywords: parity-chrome, Whiteboard: [dt-q])

Attachments

(6 files)

Attached image image.png

When deleting a CSS value, the Rules pane should have the same behavior as when the user first enters a value field: The user should see a dropdown with the possible keyword values.

This will be especially useful for the many flexbox values which are tough to remember. (Reported by :birtles)

I think it would be good to introduce a keyboard shortcut to always bring back auto-complete if it's lost. VSCode uses for example ctrl+space by default to achieve this.

Good idea! In the interim, pressing the down key on the keyboard will re-trigger the autocomplete.

Type: defect → enhancement
Priority: -- → P3

I believe this should be a dt-q bug as this was reported as frustrating by people many times.
Myself, after using the rule-view for many years, I didn't even know that pressing the down key would work, so I have developed the habit of going back to the name (shift-tab), and then back to the value again (tab). This is cumbersome, I shouldn't have to do this.
This is also a chrome-parity problem. In Chrome devtools, when you delete the value, the list re-appears automatically.
I also tested ctrl+space and it indeed works in Chrome too, so we should add this too.

Type: enhancement → defect
Keywords: parity-chrome
Whiteboard: [dt-q]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Depends on D43721

Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb477711fa64
Show the suggestions in case that the css value becomes empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/822638e9789a
Show the suggestions when user presses ctrl+space. r=pbro
https://hg.mozilla.org/integration/autoland/rev/703a2947c350
Show the suggestions in case that the css value becomes empty for new rule inspector. r=pbro
https://hg.mozilla.org/integration/autoland/rev/2081fd72fd28
Add tests in case of empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/d7b6b036d777
Add test for the shortcut key which shows the suggest completion popup. r=pbro
Status: RESOLVED → REOPENED
Flags: needinfo?(daisuke)
Resolution: FIXED → ---
Target Milestone: Firefox 70 → ---
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/158098f49ec2
Show the suggestions in case that the css value becomes empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/541172579196
Show the suggestions when user presses ctrl+space. r=pbro
https://hg.mozilla.org/integration/autoland/rev/ed8158ce9770
Show the suggestions in case that the css value becomes empty for new rule inspector. r=pbro
https://hg.mozilla.org/integration/autoland/rev/e1ba24ca37a4
Add tests in case of empty. r=pbro
https://hg.mozilla.org/integration/autoland/rev/90f33e9e1c48
Add test for the shortcut key which shows the suggest completion popup. r=pbro
Target Milestone: Firefox 70 → Firefox 71
You need to log in before you can comment on or make changes to this bug.