Closed Bug 1543786 Opened 5 years ago Closed 5 years ago

Ensure that we revoke a top frame's storage access when it is navigated away

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

Bug 1543786 - Ensure that we revoke a top frame's storage access when it is navigated away;
47 bytes, text/x-phabricator-request
Details | Review

From https://github.com/whatwg/html/issues/3338:

Access Removal

Storage access is granted for the life of the document and as long as the document's frame is attached to the DOM. This means:

Access is removed when the top frame navigates.

Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6aabad91d980
Ensure that we revoke a top frame's storage access when it is navigated away; r=baku
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/757b729752e0
follow-up: Remove a call to a non-existent function
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f63311e6f00
Fix build failure (landed on a CLOSED TREE)
Backed out 3 changesets (Bug 1543786) for browser_storageAccessRemovalNavigateTopframe.js failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4f63311e6f00d31dae05a35aa49b63c34ba3ae33&selectedJob=240090803

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/846d7680d2de2f8ae3cc55f8a448d4e8fff7f688

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=240090803&repo=mozilla-inbound&lineNumber=6366

01:38:31 INFO - TEST-START | toolkit/components/antitracking/test/browser/browser_storageAccessRemovalNavigateTopframe.js
01:40:46 INFO - TEST-INFO | started process screencapture
01:40:46 INFO - TEST-INFO | screencapture: exit 0
01:40:46 INFO - Buffered messages logged at 01:38:31
01:40:46 INFO - Entering test bound
01:40:46 INFO - Starting blocking cookieBehavior (4) and contentBlocking third-party cookies UI without allow list test Storage Access is removed when topframe navigates running in a normal window with iframe sandbox set to null and access removal set to navigate-topframe
01:40:46 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_storageAccessRemovalNavigateTopframe.js | callbackAfterRemoval must be passed when accessRemoval is non-null -
01:40:46 INFO - Creating a new tab
01:40:46 INFO - Creating a 3rd party content
01:40:46 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
01:40:46 INFO - Console message: [JavaScript Warning: "Request to access cookie or storage on “https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/3rdParty.html” was blocked because it came from a tracker and content blocking is enabled." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
01:40:46 INFO - Console message: [JavaScript Warning: "Request to access cookie or storage on “https://tracking.example.org/browser/toolkit/components/antitracking/test/browser/3rdParty.html” was blocked because it came from a tracker and content blocking is enabled." {file: "http://example.net/browser/toolkit/components/antitracking/test/browser/page.html" line: 0}]
01:40:46 INFO - Sending code to the 3rd party content
01:40:46 INFO - TEST-PASS | toolkit/components/antitracking/test/browser/browser_storageAccessRemovalNavigateTopframe.js | Doesn't yet have storage access - true == true -
01:40:46 INFO - Running after removal checks (navigate-topframe)
01:40:46 INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://not-tracking.example.com/browser/toolkit/components/antitracking/test/browser/3rdParty.html" line: 0}]
01:40:46 INFO - Buffered messages logged at 01:39:16
01:40:46 INFO - Longer timeout required, waiting longer... Remaining timeouts: 2
01:40:46 INFO - Buffered messages logged at 01:40:01
01:40:46 INFO - Longer timeout required, waiting longer... Remaining timeouts: 1
01:40:46 INFO - Buffered messages finished
01:40:46 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_storageAccessRemovalNavigateTopframe.js | Test timed out -
01:40:46 INFO - GECKO(1164) | MEMORY STAT | vsize 5734MB | residentFast 546MB | heapAllocated 94MB
01:40:46 INFO - TEST-OK | toolkit/components/antitracking/test/browser/browser_storageAccessRemovalNavigateTopframe.js | took 135039ms
01:40:46 INFO - Not taking screenshot here: see the one that was previously logged
01:40:46 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/antitracking/test/browser/browser_storageAccessRemovalNavigateTopframe.js | Found a tab after previous test timed out: http://example.net/browser/toolkit/components/antitracking/test/browser/page.html -
01:40:46 INFO - checking window state

Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19d9a16423fd
Ensure that we revoke a top frame's storage access when it is navigated away; r=baku
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2418f3bd2940
Ensure that we revoke a top frame's storage access when it is navigated away; r=baku
Flags: needinfo?(ehsan)

https://hg.mozilla.org/mozilla-central/rev/2418f3bd2940

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → ehsan
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: