Closed Bug 1543808 Opened 5 years ago Closed 5 years ago

Refactor a bit the selector parser to make Shadow Parts easier.

Categories

(Core :: CSS Parsing and Computation, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.

::slotted() is already weird in the sense that it supports a pseudo-element
afterwards (so ::slotted(*)::before is valid for example).

::part() is weirder because you are supposed to allow stuff like
::part(foo):hover, ::part(foo):hover::before, etc.

In order to avoid making the already-complex parse_compound_selector more
complex, shuffle stuff so that we pass the progress of our current compound
selector around, and is the parsing code for each selector which decides whether
it's ok to parse at the given point.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b227d4b3377
Refactor the selector parser to make implementing ::part() easier. r=xidorn
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1545462
Type: defect → task
No longer regressions: 1545462
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: