Fix incorrect max scale detection in WR border rendering.

RESOLVED FIXED in Firefox 67

Status

()

defect
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gw, Assigned: gw)

Tracking

({crash})

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 disabled, firefox66 disabled, firefox67 fixed, firefox68 fixed)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → gwatson

The local rect for border segments is not solely determined by
the widths and/or radius. Instead of determining the max scale
based on those parameters, use the calculated border segment
rects to determine an appropriate max scale factor.

Pushed by gwatson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1b702b25f53
Fix incorrect max scale detection in WR border rendering. r=emilio
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9057716 [details]
Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1519833
  • User impact if declined: WebRender crashes on sites that have borders with extremely large scale transforms.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Only affects users enrolled in WebRender, which is nVidia desktop + Win10. The patch is reasonably simple, and fixes crashes in these cases.
  • String changes made/needed:
Attachment #9057716 - Flags: approval-mozilla-beta?
No longer blocks: 1519833
Keywords: crash
Regressed by: 1519833

Comment on attachment 9057716 [details]
Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

Fix for a Webrender crash, we ship Webrender v1 in 67, uplift approved for 67 beta 11, thanks.

Attachment #9057716 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.