1543844 - Fix incorrect max scale detection in WR border rendering.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

The local rect for border segments is not solely determined by
the widths and/or radius. Instead of determining the max scale
based on those parameters, use the calculated border segment
rects to determine an appropriate max scale factor.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1b702b25f53
Fix incorrect max scale detection in WR border rendering. r=emilio

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b1b702b25f53

Comment 4

[Glenn Watson [:gw]]

Comment on attachment 9057716 [details]
Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1519833
• User impact if declined: WebRender crashes on sites that have borders with extremely large scale transforms.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only affects users enrolled in WebRender, which is nVidia desktop + Win10. The patch is reasonably simple, and fixes crashes in these cases.
• String changes made/needed:

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9057716 [details]
Bug 1543844 - Fix incorrect max scale detection in WR border rendering.

Fix for a Webrender crash, we ship Webrender v1 in 67, uplift approved for 67 beta 11, thanks.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/3445cafb3544