1543846 - Call GeckoSurfaceTexture::UpdateTexImage() at correct timing during video callback in RenderAndroidSurfaceTextureHostOGL

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Sotaro Ikeda [:sotaro]]

GeckoSurfaceTexture::UpdateTexImage() is called for each RenderAndroidSurfaceTextureHostOGL::Lock() call if GeckoSurfaceTexture is not single buffer mode. It is not good.

During video playback, one GeckoSurfaceTexture is used for all RenderAndroidSurfaceTextureHostOGLs. And the UpdateTexImage() needs to be called one for each RenderAndroidSurfaceTextureHostOGLs usage. If UpdateTexImage() is called multiple times for each usage, rendered video becomes future video frame.

Comment 1

[Sotaro Ikeda [:sotaro]]

The followings are related diagrams.
https://github.com/sotaroikeda/firefox-diagrams/blob/master/mobile/mobile_CodecProxy_68.pdf
https://github.com/sotaroikeda/firefox-diagrams/blob/master/mobile/mobile_SurfaceAllocatorService_68.pdf

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1543846 - Call GeckoSurfaceTexture::UpdateTexImage() at correct timing during video callback in RenderAndroidSurfaceTextureHostOGL

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/002bee1cab24
Call GeckoSurfaceTexture::UpdateTexImage() at correct timing during video callback in RenderAndroidSurfaceTextureHostOGL r=nical

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/002bee1cab24