1543948 - Bustages on Promise.cpp:3162:13: error: unused function 'Promise_static_allSettled' [-Werror,-Wunused-function] when Gecko 68 merges to Beta on 2019-05-06

Status: VERIFIED FIXED

(Core :: JavaScript: Standard Library, defect, P1)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central as beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=cd69ff5de89dde21e85cdd7f1d23cdff07d57bf2&selectedJob=239878172

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239878172&repo=try&lineNumber=649

:anba , this seems to be caused by Bug 1539694.
Can you please take a look?

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1543948: Add ifdef NIGHTLY_BUILD guards around all Promise.allSettled functions. r=jorendorff!

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Looks like the fix has been accepted, so it could land now ?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b550f29706a
Add ifdef NIGHTLY_BUILD guards around all Promise.allSettled functions. r=jorendorff

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jorendorff, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4b550f29706a

Comment 6

[Andreea Pavel [:apavel]]

No longer occurs in recent beta simulations:

Early: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f8f9af2af8d8d6f59cb12b0281781d60632dcfdb

Late: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=6e23ba002889a39c3cefe62b43991a1f52429f60

Comment 7

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.