1543963 - moz-phab doesn't accept . (period) in reviewer's name

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P3)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

My username in phabricator is allstars.chh
However when submitting a review with r?allstars.chh, phabricator complains
- allstars is not a valid reviewer's name

It looks like phabricator doesn't accept reviewer has a '.' in his/her username.
perhaps from https://github.com/mozilla-conduit/review/blob/master/moz-phab#L143 ?

Or if this is by design, I am okay to change my username. :P

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/hgcustom/version-control-tools/file/7951e7b5e7bf5144d1864b212f2db46e5f3ccfbb/pylib/mozautomation/mozautomation/commitparser.py#l44
https://github.com/mozilla-conduit/review/blob/master/moz-phab#L149
see IRC_NICK

Comment 2

[Zeid [:zeid]]

Attachment: commit parsing: allow periods in names (Bug 1543963) r=zalun

WIP DO NOT MERGE

Comment 3

[Zeid [:zeid]]

Attachment: Bug 1543963 - allow periods in names r=sheehan,glob

Comment 4

[Zeid [:zeid]]

Attachment: commit parsing: allow single character + period (Bug 1543963) r=zalun,glob

This change allows there to be a single character without a period as a
reviewer name, as well as adds tests to ensure that various combinations
of periods and characters work as reviewer names.

Depends on D58945

Comment 7

[John Bieling (:TbSync)]

It looks like this has a reviewed and accepted patch, can it land?

Comment 8

[Zeid [:zeid]]

Hi :TbSync -- I think we can add this to the next release. Since the revision has been sitting for a long time, I just want to do some sanity checks before we land it.