Open
Bug 1544036
Opened 5 years ago
Updated 2 years ago
Baseline ICs show up in the profiler as "Native Code" not "Baseline" code.
Categories
(Core :: JavaScript Engine: JIT, enhancement, P2)
Core
JavaScript Engine: JIT
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox68 | --- | fix-optional |
People
(Reporter: mgaudet, Unassigned)
References
Details
Attachments
(2 files)
4.97 KB,
patch
|
Details | Diff | Splinter Review | |
1.75 KB,
text/html
|
Details |
Research Question
Is the Profiler accurately capturing time in inline caches?
Experiment
Add a CacheIR op “sleep”. In the BinaryArithCache inject a sleep op if and only if the left hand side is a magical value.
Write a test case web page that allows us to profile with and without the magical value. Compare the results
Results
Indeed, we do see the time in IC stubs being reported!
However, the time in the IC is being labelled as "Native Code" rather than Baseline.
Reporter | ||
Comment 1•5 years ago
|
||
Reporter | ||
Comment 2•5 years ago
|
||
Notably: It does seem that the JS Tracer (TraceLogger) appears to be able to capture that BaselineIC should be considered Baseline code.
Reporter | ||
Comment 3•5 years ago
|
||
julianw on the DevTools slack points out that the implementation details should be correct if you filter to only JS Stacks; that does seem to be the case here.
Updated•5 years ago
|
status-firefox68:
--- → fix-optional
Priority: -- → P2
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•