1544037 - Stop doing an exists() call in StartupCache::LoadArchive()

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[:Gijs (he/him)]

https://searchfox.org/mozilla-central/rev/6dab6dad9cc852011a14275a8b2c2c03ed7600a7/startupcache/StartupCache.cpp#221-228

  bool exists;
  mArchive = nullptr;
  nsresult rv = mFile->Exists(&exists);
  if (NS_FAILED(rv) || !exists) return NS_ERROR_FILE_NOT_FOUND;

  mArchive = new nsZipArchive();
  rv = mArchive->OpenArchive(mFile);

I'd expect nsIZipArchive to complain if it gets passed a non-existent file; we should key off that instead of a separate check.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1544037 - Skip exists check when trying to open startupcache zip file archive. r?froydnj

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1544037 - Remove startupCache stat entry from main thread IO whitelist. r?florian

Depends on D31086

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c19e86931d1a
Skip exists check when trying to open startupcache zip file archive. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/8242c6c52f6c
Remove startupCache stat entry from main thread IO whitelist. r=florian

Comment 4

[Andreea Pavel [:apavel]]

Backed out for bustages at StartupCache.cpp

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=247553980&revision=8242c6c52f6c43eac5eee441a98a0742d553597f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247553980&repo=autoland&lineNumber=23231

Backout: https://hg.mozilla.org/integration/autoland/rev/acd39065fd9fa5f7fe7a4530d5a991f64dcbc9a0

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hell, how embarrassing. Sorry for the run-around - new patch coming up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79a583fd7cd9
Skip exists check when trying to open startupcache zip file archive. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/9ee0f79d80d1
Remove startupCache stat entry from main thread IO whitelist. r=florian

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/79a583fd7cd9
https://hg.mozilla.org/mozilla-central/rev/9ee0f79d80d1