1544051 - Automatically load AddTask.js in mochitest-chrome and mochitest-plain through SimpleTest.js

Status: RESOLVED FIXED

(Testing :: Mochitest, task)

Description

[Brian Grinstead [:bgrins]]

Right now to use add_task you have to explicitly include this file (https://searchfox.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/AddTask.js) with:

• mochitest-chrome: <script src="chrome://mochikit/content/tests/SimpleTest/AddTask.js"></script>
• mochitest-plain: <script src="/tests/SimpleTest/AddTask.js"></script>

I think we should be including this anywhere that loads SimpleTest.js because:

1. add_task is a nicer way to work with tests (it automatically calls SimpleTest.waitForExplicitFinish, waits for load, is async by default)
2. the script doesn't have any side effects unless called
3. it's available by default in other suites (mochitest-browser, xpcshell)

My proposal is to move the contents of AddTask.js into SimpleTest.js and then remove the separate file and any references to it.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: find-remove-addtask.sh

Script for removing <script> tags referencing AddTask.js

Comment 2

[Brian Grinstead [:bgrins]]

Haven't heard any feedback in https://groups.google.com/d/msg/mozilla.dev.platform/PqL0OC2C-90/15_zAj7_CgAJ, so I'm going to push up some patches to make this change.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1544051 - Part 1 - Move add_task into SimpleTest.js

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: Bug 1544051 - Part 2 - Remove some references to AddTask.js that aren't caught by the script in part 3

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: Bug 1544051 - Part 3 - Scripted change to remove references to AddTask.js

This was generated with the script at https://bug1544051.bmoattachments.org/attachment.cgi?id=9058672

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: Bug 1544051 - Part 4 - Remove AddTask.js

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Brian Grinstead [:bgrins] from comment #2)

Haven't heard any feedback in https://groups.google.com/d/msg/mozilla.dev.platform/PqL0OC2C-90/15_zAj7_CgAJ, so I'm going to push up some patches to make this change.

Joel, are you a good reviewer for this change, or could you recommend someone if not? I see you initially reviewed SpawnTask.js before it was renamed to AddTask.js: https://hg.mozilla.org/mozilla-central/log/22acceec0478/testing/mochitest/tests/SimpleTest/SpawnTask.js.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

:ahal would be a good reviewer for this

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77269915d66a
Part 1 - Move add_task into SimpleTest.js r=ahal
https://hg.mozilla.org/integration/autoland/rev/480e15689b61
Part 2 - Remove some references to AddTask.js that aren't caught by the script in part 3 r=ahal
https://hg.mozilla.org/integration/autoland/rev/c83490ca7185
Part 3 - Scripted change to remove references to AddTask.js r=ahal
https://hg.mozilla.org/integration/autoland/rev/dfe0b0d0827e
Part 4 - Remove AddTask.js r=ahal

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/77269915d66a
https://hg.mozilla.org/mozilla-central/rev/480e15689b61
https://hg.mozilla.org/mozilla-central/rev/c83490ca7185
https://hg.mozilla.org/mozilla-central/rev/dfe0b0d0827e