1544107 - createOffer/createAnswer fail to absorb JS state changes before resolving, violating spec.

Status: REOPENED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

In the spec, the final steps to create an offer say:

"If connection was modified in such a way that additional inspection of the system state is necessary, or if its configured indentity provider is no longer provider, then in parallel begin the steps to create an offer again, given p, and abort these steps."

It appears we don't do that. STRs:

1. Open https://jsfiddle.net/jib1/zL9njvq8/ and share camera + mic

Expected result:

negotiating
true

Actual result:

negotiating
false
negotiating
true

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Nevermind, comment 0 looks like pilot error on my part.

It seems our createOffer is mostly synchronous.

The only remaining issue here would seem to be bug 1171634.

Also, I'm wondering if this means we're firing the success callback too soon... Will open a new issue on that if that's the case.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

...and I still found a problem. I've updated the STRs.

Expected result:

negotiating
true

Actual result:

negotiating
false