1544188 - Subpixel antialiasing for text can't be turned off when WebRender is enabled

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[hujq]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

With WebRender enabled by gfx.webrender.all, try to turn off subpixel antialiasing for text by:

1. ClearType Text Tuner of Windows, choosing the third option at the third step,

OR

2. Set gfx.font_rendering.cleartype_params.cleartype_level to 0 in about:config.

Actual results:

Text is still rendered with subpixel antialiasing.

Expected results:

With WebRender disabled, either of these methods will make Firefox use grayscale antialiasing instead of subpixel.

Comment 1

[hujq]

Attachment: screenshot.png

Comment 2

[Lee Salzman [:lsalzman]]

Attachment: Bug 1544188 - check cleartype level for WR DWrite fonts. r?jfkthame

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be975934ff0a
check cleartype level for WR DWrite fonts. r=jfkthame

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/be975934ff0a

Comment 5

[Kartikaya Gupta (email:[e-mail])]

This probably warrants uplifting to 67 (I presume it is affected, didn't test). Lee, if you agree, can you request uplift?

Comment 6

[Lee Salzman [:lsalzman]]

Comment on attachment 9058366 [details]
Bug 1544188 - check cleartype level for WR DWrite fonts. r?jfkthame

Beta/Release Uplift Approval Request

• User impact if declined: WebRender users who have disabled ClearType (subpixel anti-aliasing) via the Windows font tuner will still see ClearType enabled, as the ClearType settings won't be properly respected.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just checks an OS setting for font rendering when WebRender is enabled that shouldn't affect most users.
• String changes made/needed:

Comment 7

[Pascal Chevrel:pascalc]

Comment on attachment 9058366 [details]
Bug 1544188 - check cleartype level for WR DWrite fonts. r?jfkthame

Low-risk targeted fix for webrender on Windows, uplift approved for 67 beta 13, thanks.

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a3857b3191a4

Comment 9

[Cornel Ionce [:noni] [Hubs QA]]

Marking this as qe-verify- based on comment 6.