Subpixel antialiasing for text can't be turned off when WebRender is enabled

RESOLVED FIXED in Firefox 67

Status

()

defect
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: hujq, Assigned: lsalzman)

Tracking

68 Branch
mozilla68
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox66 disabled, firefox67 fixed, firefox68 fixed)

Details

Attachments

(2 attachments)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

With WebRender enabled by gfx.webrender.all, try to turn off subpixel antialiasing for text by:

  1. ClearType Text Tuner of Windows, choosing the third option at the third step,

OR

  1. Set gfx.font_rendering.cleartype_params.cleartype_level to 0 in about:config.

Actual results:

Text is still rendered with subpixel antialiasing.

Expected results:

With WebRender disabled, either of these methods will make Firefox use grayscale antialiasing instead of subpixel.

Component: Untriaged → Graphics: WebRender
Product: Firefox → Core
Posted image screenshot.png
Assignee: nobody → lsalzman
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be975934ff0a
check cleartype level for WR DWrite fonts. r=jfkthame
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

This probably warrants uplifting to 67 (I presume it is affected, didn't test). Lee, if you agree, can you request uplift?

Blocks: wr-67
Priority: -- → P2

Comment on attachment 9058366 [details]
Bug 1544188 - check cleartype level for WR DWrite fonts. r?jfkthame

Beta/Release Uplift Approval Request

  • User impact if declined: WebRender users who have disabled ClearType (subpixel anti-aliasing) via the Windows font tuner will still see ClearType enabled, as the ClearType settings won't be properly respected.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just checks an OS setting for font rendering when WebRender is enabled that shouldn't affect most users.
  • String changes made/needed:
Attachment #9058366 - Flags: approval-mozilla-beta?

Comment on attachment 9058366 [details]
Bug 1544188 - check cleartype level for WR DWrite fonts. r?jfkthame

Low-risk targeted fix for webrender on Windows, uplift approved for 67 beta 13, thanks.

Attachment #9058366 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Marking this as qe-verify- based on comment 6.

Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.