Closed Bug 1544393 Opened 8 months ago Closed 9 days ago

Ship remote agent in Nightly

Categories

(Remote Protocol :: Agent, enhancement, P1)

enhancement

Tracking

(firefox73 fixed)

RESOLVED FIXED
Tracking Status
firefox73 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [puppeteer-alpha])

Attachments

(1 file)

The narrative of https://bugzilla.mozilla.org/show_bug.cgi?id=1533831
has changed from shipping the remote agent in Nightly, to turning
it on only for try tests. This will be achieved by first flipping
the remote.enabled preference to false and then implying
--enable-cdp for the default build.

This bug now tracks shipping the remote agent in Nightly, which
code-wise is effectively about reversing the effect of remote.enabled.
This bug is blocked by security review.

Summary: Turn remote agent on in Nightly → Ship remote agent in Nightly
Assignee: nobody → ato
Status: NEW → ASSIGNED
Type: defect → enhancement
Depends on: 1533831
OS: Unspecified → All
Hardware: Unspecified → All
Priority: -- → P2
No longer blocks: 1542229
Depends on: 1542229
Status: ASSIGNED → NEW
Priority: P2 → P3
Assignee: ato → nobody

We found that this is in fact not a dependency for puppeteer-mvp,
since our fork of the Puppeteer client can ensure to set the
remote.enabled preference in the profile’s user.js file before
starting Firefox.

However, I suspect the security review will be done by the time we
are ready to ship the MVP anyway, and we should plan for that, since
it’s the path of least resistance.

No longer blocks: puppeteer-mvp
Depends on: 1580470

Since we are in nightly now and work with puppeteer client that sets the necessary prefs to get things turned on do we need this bug anymore?

Flags: needinfo?(ato)

As you say, Puppeteer will work but only because it modifies the profile.
Now that the security review in bug 1542229 and the follow-up work that came out of it is complete,
we should simply go ahead and flip this preference.

Assignee: nobody → ato
Status: NEW → ASSIGNED
Flags: needinfo?(ato)
Priority: P3 → P1
Whiteboard: [puppeteer-alpha-reserve]

I spotted a bug in https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#4842
where remote.enabled is being installed regardless of whether ENABLE_REMOTE_AGENT is set.

Now that the security review in bug 1542229 and the follow-up work
that came out of it is complete, we should go ahead and flip the
remote.enabled preference.

This patch causes the remote agent to be available to users on the
Firefox Nightly release channel. This meansusing --remote-debugger
will no longer cause a fatal error

Blocks: 1600330
Pushed by atolfsen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a69d75cf9b1
remote: ship remote agent in Firefox Nightly r=remote-protocol-reviewers,whimboo,maja_zf
Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Whiteboard: [puppeteer-alpha-reserve] → [puppeteer-alpha]
You need to log in before you can comment on or make changes to this bug.