1544489 - xpinstallPromptMessage cannot be properly translated in some cases

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

From :piotrdrag

This is not translatable to my language. “an unknown site” needs different translations in xpinstallPromptMessage.header and xpinstallPromptMessage.message. Preferably, the versions for an unknown site would be separate strings. Do I need to reopen this bug, or file a new one?

https://searchfox.org/mozilla-central/rev/0376cbf447efa16922c550da3bfd783b916e35d3/browser/locales/en-US/chrome/browser/browser.properties#23-31

We probably need a couple strings to support localization better:

xpinstallPromptMessage.header=Allow %S to install an add-on?
xpinstallPromptMessage.message=You are attempting to install an add-on from %S. Make sure you trust this site before continuing.

xpinstallPromptMessage.header.unknown=an unknown site
xpinstallPromptMessage.message.unknown=an unknown site

An alternate option that should always work would be:

xpinstallPromptMessage.header.unknown=Allow an unknown site to install an add-on?
xpinstallPromptMessage.message.unknown=You are attempting to install an add-on from an unknown site. Make sure you trust this site before continuing.

However in that case we loose the bold style for "an unknown site".

Comment 1

[Shane Caraveo (:mixedpuppy)]

:flod Is there any way for me to know whether the first option above is still going to present translation issues?

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #1)

:flod Is there any way for me to know whether the first option above is still going to present translation issues?

This is not the request from Piotr (and I got the same from Michal for Czech).

It should be completely different strings, e.g.

xpinstallPromptMessageDomain.header=Allow %S to install an add-on?
xpinstallPromptMessageDomain.message=You are attempting to install an add-on from %S. Make sure you trust this site before continuing.

xpinstallPromptMessageUnknown.header=Allow add-on installation from unknown source?
xpinstallPromptMessageUnknown.message=You are attempting to install an add-on from an unknown source. Make sure you trust this file before continuing.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1544489 use separate strings to localize install prompt for unknown sites.

Comment 4

[Francesco Lodolo [:flod]]

Is there anything holding this patch from landing?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7f798e98a75
use separate strings to localize install prompt for unknown sites. r=flod,aswan

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/d7f798e98a75