1544570 - Add-on downloads briefly flash "NaN bytes/sec" when a download starts

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of bug

STR:

1. Visit https://profiler.firefox.com/ and click through to install the Gecko Profiler add-on.

ACTUAL RESULTS:
When the add-on download starts, it briefly flashes the following text under the progress bar:

Unknown time left -- 0 bytes (NaN bytes/sec)

EXPECTED RESULTS:
We should never report a speed of NaN.

Note:
You may have to use a screen recorder to capture this moment of time -- it's very brief, but I did notice it visually when downloading an addon today (which prompted me to investigate, do a screen recording, and file this bug).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of bug (0:02)

Here's the screencast that the attached screenshot is taken from.

The error happens at around 0:02 seconds.

Comment 2

[Daniel Holbert [:dholbert]]

Note: I'm not sure whether internet speed affects reproducibility, but if it matters, I do have a fairly fast connection (~130Mbps right now according to speedtest.net).

I'm also not sure what the right component is for this "add-on downloading" doorhanger experience; if I got it wrong, please recategorize as appropriate - thanks!

Comment 3

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

The priority flag is not set for this bug.
:ddurst, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Joshua O'Brien]

Hello, I have a fix for this. Will open a change request soon, just reading the guidelines

Comment 5

[Joshua O'Brien]

Attachment: Bug 1544570 - Don't update progress if no discernible amount of time has passed. r=johannh

Comment 6

[Caitlin Neiman [:caitmuenster]]

Hi Joshua! how's it going with this bug?

Comment 7

[Caitlin Neiman [:caitmuenster]]

Hi Joshua, since we haven't heard from you in awhile we are going to unassign you from this bug and let other folks take it up. If you would like to keep working on it, please leave a comment or submit a patch.

Comment 8

[Andrew Park]

Hi, I would like to pick this one up. I will submit a patch soon.

Comment 9

[Andrew Park]

Attachment: Bug 1544570 - Set minimum time delta value to avoid division by zero. r=zombie

Comment 10

[Joshua O'Brien]

Hey sorry, had some life stuff going on and didn't get a chance to action the feedback on my initial patch. I plan to fix that up this weekend.

Comment 11

[Joshua O'Brien]

Oh I see you already made a patch, all good.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e9dd54bc629
Set minimum time delta value to avoid division by zero. r=zombie

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9e9dd54bc629

Comment 14

[Caitlin Neiman [:caitmuenster]]

Thanks so much for your contribution, Andrew! ✨ Your contribution has been added to our recognition wiki at https://wiki.mozilla.org/Add-ons/Contribute/Recognition.

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

Comment 15

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Reproduced the initial issue using an old Nightly build from 2019-04-15. Verified that this issue is fixed using latest Firefox 80.0b5 across platforms (Windows 10 64bit, macOS 10.15 and Ubuntu 18.04 64bit) and with the help of this extension https://1password.com/browsers/firefox/