1544572 - Support compositor recording for LayerManagerComposite

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Beth Rennie [:beth] (she/her)]

The infrastructure in bug 1536174 presently only works with the LayerManagerMLGPU. It would be great it if it could also support the OpenGL compositor and we could get more platform coverage.

Comment 1

[Beth Rennie [:beth] (she/her)]

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=42cca5a59db41c1b728f9f144978f0580695a587

Comment 2

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1544572 - Support composition recording for LayerManagerComposite r?mstange

Comment 3

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1544572 - Add composition recorder support to CompositorOGL r?mstange

Depends on D27820

Comment 4

[Beth Rennie [:beth] (she/her)]

New try build that supports all compositors.

Comment 5

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1544572 - Support composition recording for BasicCompositor r?mstange

The LayerManagerComposite can now request its compositor to record frames
(i.e., ensure there is a window render target). For all compositors except
BasicCompositor, this is a no-op since they already always have one.

Now the BasicCompositor keeps track of whether or not should be recording
frames based on this request from the LayerManagerComposite and information
about the profiler. This also has the benefit of cleaning up some of the code
that was conditionally compiled only on platforms that support the profiler.

Depends on D27820

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22b1b841ad35
Support composition recording for LayerManagerComposite r=mstange
https://hg.mozilla.org/integration/autoland/rev/cff5f2d11f52
Support composition recording for BasicCompositor r=mstange

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/22b1b841ad35
https://hg.mozilla.org/mozilla-central/rev/cff5f2d11f52