1544594 - Reader View should not inline New York Time Glossary spans

Status: NEW

(Toolkit :: Reader Mode, defect, P3)

Description

[Paul Lindner]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. Visit a New York Times Article with "Glossary" Markup like:

https://www.nytimes.com/2019/04/10/opinion/privacy-feminism.html

2. Click Reader View Icon

Actual results:

"Glossary" html is rendered inline, like this:

Even well-meaning efforts at transparencyTaking appropriate measures to provide any information relating to processing to the data subject in a concise, intelligible and easily accessible form, using clear and plain language. GlossaryClose X don’t always work that way for women.

The section from "Taking appropriate..." to "Glossary Close X" is a tooltip.

Expected results:

Glossary Items should not be displayed.

Example HTML markup:

<span class="glossary-wrapper">
<span class="glossary-text">transparency</span>
<span class="glossary-info">
<span class="glossary-definition">Taking appropriate measures to provide any information relating to processing to the data subject in a concise, intelligible and easily accessible form, using clear and plain language. <a href="https://www.nytimes.com/interactive/2019/04/10/opinion/internet-privacy-terms.html" target="_blank">Glossary</a>
</span><img class="close-tooltip" src="https://static01.nyt.com/newsgraphics/2019/01/22/tooltip-template/1e41ab3eab12f1354e056fb2fa3acc6d09df13e2/close.svg" alt="Close X">
</span><span></span></span>

Comment 1

[:Gijs (he/him)]

This needs addressing in the readability library and I filed https://github.com/mozilla/readability/issues/540 for this.