Closed Bug 1544631 Opened 6 years ago Closed 6 years ago

mips branchTestBigInt negPtr generateVMWrapper

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
68 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: qiaopengcheng-hf, Assigned: qiaopengcheng-hf)

References

Details

Attachments

(2 files, 2 obsolete files)

Fix functions branchTestBigInt negPtrgenerateVMWrapper on MIPS
11.81 KB, patch
Details | Diff | Splinter Review
Bug 1544631 - Fix functions: branchTestBigInt, negPtr, generateVMWrapper on MIPS.
47 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101 Firefox/52.0

Steps to reproduce:

compiling the JS code on mips-linux

Actual results:

compiling the JS code on mips-linux, these functions:
branchTestBigInt, negPtr, generateVMWrapper
are not properly ported.

Expected results:

should compile sucessfully

Attachment #9058471 - Flags: checkin?(jdemooij)
Attachment #9058471 - Attachment is obsolete: true
Attachment #9058471 - Flags: checkin?(jdemooij)
Attachment #9058476 - Flags: checkin?(jdemooij)

Hi, please request the review+ before landing this.

Flags: needinfo?(qiaopengcheng-hf)

(In reply to Daniel Varga [:dvarga] from comment #3)

Hi, please request the review+ before landing this.

There is no selection for reviewer after review+.

Flags: needinfo?(qiaopengcheng-hf)
Comment on attachment 9058476 [details] [diff] [review] Fix functions branchTestBigInt negPtrgenerateVMWrapper on MIPS I remeber that seletion review+ will ask a reviewer. But now I can't find it.
Flags: needinfo?(dvarga)
Attachment #9058476 - Flags: checkin?(jdemooij) → review+

This still needs to be reviewed by jdemoolj.

Flags: needinfo?(dvarga) → needinfo?(jdemooij)

Please post patches using Phabricator nowadays, https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Flags: needinfo?(jdemooij)
Attachment #9058476 - Flags: review+

qiaopengcheng, thank you for the patch. Please note that MIPS support may be dropped in the future.

(In reply to Mike Conca [:mconca] from comment #8)

qiaopengcheng, thank you for the patch. Please note that MIPS support may be dropped in the future.

Our company wants to maintains the mips and had expressed within the dev-tech-js-engine-internals@lists.mozilla.org

Fix functions: branchTestBigInt, negPtr, generateVMWrapper on MIPS.

Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00719f1766c1 Fix functions: branchTestBigInt, negPtr, generateVMWrapper on MIPS. r=jandem

https://hg.mozilla.org/mozilla-central/rev/00719f1766c1

Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → qiaopengcheng-hf

Bug 1544631 - part2: amend Bug-1544631 for fixing mips32.

Depends on: 1556197

Comment on attachment 9069168 [details]
Bug 1544631 - part2: amend Bug-1544631 for fixing mips32.

Revision D33402 was moved to bug 1556197. Setting attachment 9069168 [details] to obsolete.

Attachment #9069168 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: