1544757 - Failed assertion MOZ_ASSERT(mRaceCacheWithNetwork || !(mTransactionPump && mCachePump) || mCachedContentIsParMOZ_ASSERT(mRaceCacheWithNetwork || !(mTransactiontial, "If we have both pumps, the cache content must be partial");

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Dragana Damjanovic [:dragana]]

I notice this assertion failure in nsHttpChannel:

MOZ_ASSERT(mRaceCacheWithNetwork || !(mTransactionPump && mCachePump) ||
mCachedContentIsPartial,
"If we have both pumps, the cache content must be partial");

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I've got this assertion with D36301 with enabling fission.autostart when I click "Treeherder Jobs" image in a mail from Taskcluster on mail.google.com.

Comment 2

[Jean-Yves Avenard [:jya]]

This is what I'm doing and this reproduce very consistently.

1. Build gecko
2. ./mach clobber
3. ./mach run
4. go to about:config, enable fission
5. quit
6. ./mach run
7. go to cnn.com ; wait for the page to load
8. quit elegantly (ctrl-shift-q)
9. ./mach run

This will assert once the session is restored about 80% of the time

Comment 3

[Hiroyuki Ikezoe (:hiro)]

This assertion happens on reddit.com during scrolling the contents by wheel scroll. Just before the assertion happens I see
NS_ENSURE_TRUE(mSuspendCount > 0) failed.

Comment 4

[Jean-Yves Avenard [:jya]]

This is the most common assertions encountered when I have fission enabled

Comment 5

[Michal Novotny [:michal]]

I cannot reproduce it. If you can reproduce it consistently, could you please provide HTTP log? See https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging

Comment 6

[Hiroyuki Ikezoe (:hiro)]

I can still see the assertion with the way I mentioned in comment 1. I also see the warning in comment 3 at that time.

Comment 7

[Nhi Nguyen (:nhi)]

:hiro, could you please provide HTTP logs for the assertion? Thanks!

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Attachment: log.zip

Here, it's a log when I clicked the "Treeherder Jobs" image in a message on gmail.com. I wonder why other people can't reproduce this assertion. It's pretty easy to reproduce for me.

Comment 9

[Michal Novotny [:michal]]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #8)

Here, it's a log when I clicked the "Treeherder Jobs" image in a message on gmail.com.

Thanks for the log. Unfortunately, the log doesn't contain information just before the assertion. Can you please add "sync" keyword to the list of logging modules?
https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/HTTP_logging#Use_'sync'_if_your_browser_crashes_or_hangs

I wonder why other people can't reproduce this assertion. It's pretty easy to reproduce for me.

Racing is sensitive to exact timing and I guess my HW setup doesn't trigger this assertion.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Attachment: A log with sync flag

Comment 11

[Michal Novotny [:michal]]

Attachment: Bug 1544757 - Failed assertion MOZ_ASSERT(mRaceCacheWithNetwork || !(mTransactionPump && mCachePump) || mCachedContentIsPartial), r=mayhemer

When revalidated cache entry is used, normally the sequence is:
OnStartRequest(mTransactionPump)
OnStopRequest(mTransactionPump)
OnStartRequest(mCachePump)
OnStopRequest(mCachePump)

When doing cross process redirect, the call to OnStopRequest(mTransactionPump) might get delayed, so we can still have mTransactionPump in OnStartRequest(mCachePump).

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3feee5147ab0
Failed assertion MOZ_ASSERT(mRaceCacheWithNetwork || !(mTransactionPump && mCachePump) || mCachedContentIsPartial), r=mayhemer

Comment 13

[Razvan Maries]

Backed out for dt perma failurest on browser_parsable_css.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=262105174&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=3feee5147ab0c9a7647f920bb0dde9950c836bed&searchStr=dt

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=262105174&repo=autoland&lineNumber=13381

Backout: https://hg.mozilla.org/integration/autoland/rev/9577cd6cb5beaa157968e92f68b62bbb514ad7db

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/836eaf6f89c1
Failed assertion MOZ_ASSERT(mRaceCacheWithNetwork || !(mTransactionPump && mCachePump) || mCachedContentIsPartial), r=mayhemer

Comment 15

[Narcis Beleuzu [:NarcisB]]

This push was not the cause for for the dt perma failures on browser_parsable_css.js

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/836eaf6f89c1

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.