154481 - Account Settings top panel should have a unique name

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Ninoschka Baca]

Overview: Open the Account Settings window and try to describe how to select the
first panel for an account. It's difficult because the first panel itself is
called Account Settings. I would like the first panel to have a unique name. 

Maybe it could be called Identity Settings. Jen do you have any suggestions?

Comment 1

[Ninoschka Baca]

Assigning to varada.

Comment 2

[varada]

Attachment: Patch V1

Changing Account Settings to "Identity Settings"

Comment 3

[Srilatha Moturi]

Comment on attachment 89452 [details] [diff] [review]
Patch V1

looks good 
r=srilatha

Comment 4

[David :Bienvenu]

Jen (or Robin?) should review. I'll sr it, but please get one of them to review it.

Comment 5

[David :Bienvenu]

Comment on attachment 89452 [details] [diff] [review]
Patch V1

sr=bienvenu

Comment 6

[jglick]

nbaca, the top level panel is the parent to its sub panels. Would it be odd that 
the other panels, Server settings, Copies and Folders, etc, appear as children 
of "Identity Settings"?

More acurately it would be:
Account Settings
   Identity
   Server Settings
   Copies and Folders
   Etc.

But since we have data at the top level, it makes this confusing.

What if each top level item read "Account Settings - <Account Name>"? Then each 
top level would be unique, but still accurate in that its the parent level to 
all the settings for that account.

Comment 7

[varada]

Attachment: New Patch V1.0

Patch as per jennifer's proposed solution. We obtain the account name from the
page and then set the page dialogheader. Incase we dont get a value there is a
default Title which is Account Settings which will be set.

Comment 8

[Srilatha Moturi]

Comment on attachment 100187 [details] [diff] [review]
New Patch V1.0

So, i ssume you are using defaultTitle as an attribute because it will help get
the default ("AccountSettings") each time instead of adding to existing
pageData values.
r=srilatha

Comment 9

[Scott MacGregor]

Could you just set the title directly on am-main-title instead of using a
defaultTitle field?

Then your JS code can just worry about the case where you do generate a new
title name and just set it in that case. 

Comment 10

[varada]

I didnt quite understand your comments scott.
The reason I use the defaultTitle attribute is to store the "Account Settings"
string.
Are you suggesting that, instead of storing it as an attribute in the xul,we use
the string directly from js and set the title value each time?

Comment 11

[Scott MacGregor]

Is defaultTitle some particular attribute that gets used by the wizard or is it
something you made up? 

I was suggesting:
<dialogheader id="am-main-title" title="&accountTitle.label;"/>

then

if(accountName.value)
    title.setAttribute("title", defaultTitle+" - <"+accountName.value+">");

Comment 12

[varada]

If I tried using title="&accountTitle.label;" the first time I get the title it
would be "Account Settings" - next time it would be 
"Account Settings-<accountName1>" and so on.
So I store the string separately and set the value to title each time using that
string.
I use the defaultTitle attribute as a storage place for the string. If I did it
in js I would probably have to store it in a .properties file instead of .dtd. 

Comment 13

[Scott MacGregor]

Comment on attachment 100187 [details] [diff] [review]
New Patch V1.0

but subsquent loads of the dialog wouldn't know anything about previous times
the dialog was opened. The XUL and JS get re-initialized each time an overlay
is loaded. So you wouldn't end up with:
"Account Settings-<accountName1>-<accountName2>-<accountName3>

or am i missing something?

Comment 14

[varada]

Subsequent loads wouldnt have a problem but if you are selecting different
accounts then each time we re-use the existing panel and merely reload with
new(er) values from accountData. 
  In the case of the Account Settings title - the value is not currently stored
in the accountData because it is not part of the account(unlike say servername
or identityname etc..).
 Storing the title as part of accountData is not right because it is really not
necessary for the account and only for the UI.
 So when we desire to have different titles there we should make sure that the
previous value is dumped before the new one is set.
I hope this clarifies the issue.

Comment 15

[Scott MacGregor]

Comment on attachment 100187 [details] [diff] [review]
New Patch V1.0

ok, thanks for the clarification.

Comment 16

[varada]

Marking Fixed.

Comment 17

[Ninoschka Baca]

Buffy Trunk build 2002-10-29: WinMe, Linux 8, Mac 10.1.3
Verified Fixed. In the form of "Account Settings <Account Name>.