1544867 - Make AS devtools collapsible

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Kate Hudson :k88hudson]

In order for us to test under-search-bar snippets, we should make the AS devtools collapsible. That way we can observe the actual behaviour of snippets etc.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4908

Comment 2

[Kate Hudson :k88hudson]

Heads up that once this lands in nightly, if you have browser.newtabpage.activity-stream.asrouter.devtoolsEnabled set to true you will see a button show up in the top left hand corner of the new tab page (see attached screenshot).

QA steps

1. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to false. Open about:newtab. Ensure you do NOT see a yellow button in the top left hand corner.
2. Set the above pref to true. Ensure you now see a button that says "Expand Devtools".
3. Click the button. The button should now say "Collapse Devtools". You should see the devtools appear on the page. Ensure they are working normally and you can scroll.
4. Click the button again. Ensure you now see the regular new tab page and can scroll.
5. Set browser.newtabpage.activity-stream.asrouter.devtoolsEnabled to false again. Ensure you see a regular new tab now and that the yellow button disappears.

Regression testing

Please also check snippets are working normally in both settings of the devtools pref.

Comment 3

[Kate Hudson :k88hudson]

Attachment: Screenshot of expand/collapse button

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8ff5048f2b90

Comment 5

[Ed Lee :Mardak]

The styling changed to be a wrench icon in top right instead of the original yellow button top left:

https://github.com/mozilla/activity-stream/pull/4927

Exported as part of bug 1546535
https://hg.mozilla.org/mozilla-central/rev/01c3e1ae707d

Comment 6

[Ed Lee :Mardak]

Attachment: wrench button

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Using comment 3 and comment 5, I have verified this issue on the latest Nightly 68.0a1 (Build ID 20190424095359) on Windows 10 x64, Mac 10.14, and Arch Linux 4.14.3.