1544927 - Telemetry on integrated abuse reporting

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P1)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As part of Bug 1540175, we'll need to record some telemetry related to the integrated abuse reporting.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: data-review-request-bug-1544927.md

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1544927 - Record telemetry on integrated about:addons abuse reporting. r=aswan,janerik

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9061328 [details]
data-review-request-bug-1544927.md

This data review request is related to an additional telemetry event related to the abuse report submissions (and so it is a separate data review from the one related to the abuse report data collection, attached to Bug 1543377).

Comment 4

[Chris H-C :chutten]

Comment on attachment 9061328 [details]
data-review-request-bug-1544927.md

Preliminary notes:

This is an excellently-detailed review request. Thank you for going to this level of detail in your answer to Q5.

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 73.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :rpl is responsible for renewing or removing the collection before it expires in Firefox 73.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/692bd19485ff
Record telemetry on integrated about:addons abuse reporting. r=aswan,janerik

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/692bd19485ff

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

STR for QA verification:

• open about:telemetry in a tab and select the events view
• submit a report on an extension
  • on a successfully submitted report:
    • new telemetry events recorded with the following properties:
      • category: addonsManager
      • method: report
      • object: <REPORT_ENTRYPOINT> (1)
      • value: <ADDON_ID>
      • extra.addon_type: <ADDON_TYPE>
  • on a submission error:
    • new telemetry events recorded with the same properties listed above, plus extra.error_type: <ERROR_TYPE> (2)

---

(1): where <REPORT_ENTRYPOINT> can be:

• menu (report triggered from HTML about:addons report action)
• toolbar_context_menu (report triggered from browserAction's "Report Extension" context menu action)
• uninstall (report triggered from the checkbox included in the uninstall extension dialog)

(2): where <ERROR_TYPE> can be one of the following strings (based on the error triggered): "ERROR_ABORTED_SUBMIT", "ERROR_CLIENT", "ERROR_NETWORK", "ERROR_UNKNOWN", "ERROR_RECENT_SUBMIT", "ERROR_SERVER"

Comment 8

[Victor Carciu]

Verified as fixed in FF Nightly 69.0a1 (2019-06-13) and FF Beta 68.0b8 (64-bit) on Windows 10x64 and macOS 10.14.5

Please see attached postfix screenshot

Comment 9

[Victor Carciu]

Attachment: Postfix Screenshot