Closed Bug 1544940 Opened 5 years ago Closed 5 years ago

[mozdevice] launch_activity has incorrect default intent action string

Categories

(Testing :: Mozbase, defect, P1)

Version 3
defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: rwood, Assigned: gbrown)

Details

Attachments

(1 file)

ADBDevice.launch_activity is using default intent="android.intent.action.Main" [0], but should be intent="android.intent.action.MAIN".

(comment by :nalexander in a different phab review):
This should be capital MAIN. Main is probably ignored, which defaults to MAIN, I expect. See https://developer.android.com/reference/android/content/Intent.html#ACTION_MAIN

[0] https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/testing/mozbase/mozdevice/mozdevice/adb.py#3095

Assignee: nobody → gbrown
Priority: -- → P1
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8701216ef356
[mozdevice] Fix typo in default intent name; r=bc
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: