[mozdevice] launch_activity has incorrect default intent action string

RESOLVED FIXED in Firefox 68

Status

defect
P1
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: rwood, Assigned: gbrown)

Tracking

Version 3
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 months ago

ADBDevice.launch_activity is using default intent="android.intent.action.Main" [0], but should be intent="android.intent.action.MAIN".

(comment by :nalexander in a different phab review):
This should be capital MAIN. Main is probably ignored, which defaults to MAIN, I expect. See https://developer.android.com/reference/android/content/Intent.html#ACTION_MAIN

[0] https://searchfox.org/mozilla-central/rev/1b2636e8517aa48422ed516affe4d28cb7fa220a/testing/mozbase/mozdevice/mozdevice/adb.py#3095

Assignee

Updated

2 months ago
Assignee: nobody → gbrown
Priority: -- → P1

Comment 2

2 months ago
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8701216ef356
[mozdevice] Fix typo in default intent name; r=bc

Comment 3

2 months ago
bugherder
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.