Closed Bug 1545120 Opened 2 years ago Closed 2 years ago

nsTimerImpl does not really need mCallbackDuringFire

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox-esr60 --- fixed
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(2 files)

It does not seem that the extra complexity to avoid refcount manipulation (by swapping) is worth it here. mCallbackDuringFire really ought to be a stack copy of mCallback.

Assignee: nobody → docfaraday
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd62ad8bf26d
Simplify this callback management stuff a little. r=froydnj
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.