1545120 - nsTimerImpl does not really need mCallbackDuringFire

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Byron Campen [:bwc]]

It does not seem that the extra complexity to avoid refcount manipulation (by swapping) is worth it here. mCallbackDuringFire really ought to be a stack copy of mCallback.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1545120: Simplify this callback management stuff a little.

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=db4bbacc59aa030ecc060a7f3f73227dd074713d

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd62ad8bf26d
Simplify this callback management stuff a little. r=froydnj

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bd62ad8bf26d

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1545120: (ESR60 backport) Simplify this callback management stuff a little.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/198b3248e141

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/d44b551abaf9