1545163 - Expose private browsing flag on proxy/webrequest details

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, enhancement)

Description

[Shane Caraveo (:mixedpuppy)]

We want some additional/simplified flags on the details objects received in webrequest and proxy event APIs.

• private browsing flag
• container id
• tracker information (see TrackingClassification[1] and ClassOfService[2])
  needs better definition, probably split out into separate bug

[1] https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/netwerk/protocol/http/HttpTrafficAnalyzer.h#27

[2] https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/netwerk/protocol/http/HttpTrafficAnalyzer.h#21

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 2

[Rob Wu [:robwu]]

Bug 1391992 is about adding the "cookieStoreId" property to webRequest events (this reflects the container ID).

Comment 3

[Shane Caraveo (:mixedpuppy)]

bug 1391992 will expose the container id

This bug is reduced to the private flag.

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1545163 add incognito flag to proxy and webrequest details

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=89c68db5d0dd73e34f31f8d1db25436f855bddb6

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca2e07d3caad37fbfe85a5acd807da7b4b22b128

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ba49ce135e6
add incognito flag to proxy and webrequest details r=robwu

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7ba49ce135e6

Comment 9

[Madalin Cotetiu]

Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "

Comment 10

[Shane Caraveo (:mixedpuppy)]

covered by tests

Comment 11

[Irene Smith]

Added a definition of the new flag to proxy.RequestDetails:

incognito
boolean true for private browing requests

It is also included in the Release notes.