Closed Bug 1545163 Opened 5 years ago Closed 5 years ago

Expose private browsing flag on proxy/webrequest details

Categories

(WebExtensions :: Request Handling, enhancement)

Product:
WebExtensions
Component:
Request Handling
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Bug 1545163 add incognito flag to proxy and webrequest details
47 bytes, text/x-phabricator-request
Details | Review

We want some additional/simplified flags on the details objects received in webrequest and proxy event APIs.

  • private browsing flag
  • container id
  • tracker information (see TrackingClassification[1] and ClassOfService[2])
    needs better definition, probably split out into separate bug

[1] https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/netwerk/protocol/http/HttpTrafficAnalyzer.h#27

[2] https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/netwerk/protocol/http/HttpTrafficAnalyzer.h#21

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Type: task → enhancement

Bug 1391992 is about adding the "cookieStoreId" property to webRequest events (this reflects the container ID).

See Also: → 1391992

bug 1391992 will expose the container id

This bug is reduced to the private flag.

Summary: Expose additional details on request events → Expose private browsing flag on proxy/webrequest details
Assignee: nobody → mixedpuppy
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7ba49ce135e6
add incognito flag to proxy and webrequest details r=robwu
Keywords: dev-doc-needed

https://hg.mozilla.org/mozilla-central/rev/7ba49ce135e6

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "

Flags: needinfo?(mixedpuppy)

covered by tests

Flags: needinfo?(mixedpuppy) → qe-verify-

Added a definition of the new flag to proxy.RequestDetails:

incognito
boolean true for private browing requests

It is also included in the Release notes.

Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.