Closed Bug 1545230 Opened 7 months ago Closed 7 months ago

Some gtests in layout/base/gtest are not run on Android

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: gbrown, Assigned: TYLin)

References

Details

Attachments

(1 file)

Bug 1318091 started running gtest on our Android 7.0 test platform: gtest runs in the geckoview TestRunnerActivity, against an x86_64 build, running in an emulator running Android 7.0 on packet.net.

Many gtests run fine and pass consistently, but others did not and have been disabled.

layout/base/gtest tests disabled on Android can be found at:

https://searchfox.org/mozilla-central/rev/d33d470140ce3f9426af523eaa8ecfa83476c806/layout/base/gtest/moz.build#8

Looks like the tests in question are:

    'TestAccessibleCaretEventHub.cpp',
    'TestAccessibleCaretManager.cpp',

--> ni TYLin who added them. (And adding dependency on bug 1204872 where they were added and bug 1318091 where they were disabled)

Depends on: 1318091, 1204872
Flags: needinfo?(aethanyc)
Priority: -- → P3

A try to enable AccessibleCaret's gtests on Android to see the errors.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e46dac399ac5a62947f02d0c31f814f85ce2f776

These gtests are designed under the default preferences in mind. On
Android, some of the preferences have different values, so we need to
set them back to default value at the beginning of the tests so they
don't fail on Android.

Assignee: nobody → aethanyc
Status: NEW → ASSIGNED
Flags: needinfo?(aethanyc)
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/449637009846
Enable AccessibleCaret gtests on Android. r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.