1545279 - Crash in [@ monitor_device_notifications::notify]

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[[:philipp]]

This bug is for crash report bp-883c36f7-d02e-4b41-9377-0135b0190415.

Top 10 frames of crashing thread:

0 xul.dll void monitor_device_notifications::notify media/libcubeb/src/cubeb_wasapi.cpp:315
1 xul.dll HRESULT wasapi_collection_notification_client::OnDeviceStateChanged media/libcubeb/src/cubeb_wasapi.cpp:492
2 mmdevapi.dll CDeviceEnumerator::OnDeviceStateChangedNoLock 
3 mmdevapi.dll CDeviceEnumerator::OnAsyncNotification 
4 mmdevapi.dll CDeviceEnumerator::AsyncNotificationCallback 
5 ntdll.dll TppWorkpExecuteCallback 
6 ntdll.dll TppWorkerThread 
7 kernel32.dll BaseThreadInitThunk 
8 mozglue.dll static void patched_BaseThreadInitThunk mozglue/build/WindowsDllBlocklist.cpp:712
9 ntdll.dll RtlUserThreadStart 

this is a low volume tab crash signature that's showing up in 67.0b in a codepath added in bug 1527659.

Comment 1

[Alex Chronopoulos [:achronop]]

Fix under review: https://github.com/kinetiknz/cubeb/pull/505

Comment 2

[Pascal Chevrel:pascalc]

Too low volume in beta and too late in the beta cycle for a potential uplift, wontfix 67.

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1545279 - Update cubeb from upstream to 3570749. r?padenot

Pick commits:
3570749 - wasapi: tie monitor lifetime with notification client lifetime. BMO 1545279 (#505)
162625a - test: add option to get the posotion of a stream (#504)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ba614682b62
Update cubeb from upstream to 3570749. r=padenot

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3ba614682b62