1545328 - Some column set frame cleanup

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P3)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Some cleanup I'd like to do while figuring out how column reflow works.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 1 - Change two FindBestBalanceBSize()'s arguments to be passed by value.

No code after FindBestBalanceBSize() is interested in
aUnboundedLastColumn and aRunWasFeasible, so they don't need to be
input/output arguments.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 2 - Remove "virtual" keywords for methods that already have "override".

Depends on D28009

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 3 - Stop exposing ClampUsedColumnWidth() in the header.

The static function is used only in nsColumnSetFrame's implementation.

Depends on D28010

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 4 - Replace "height" with "block-size" in comments.

I manually search "height" and replace it with "block-size" if the code
around it uses logical coordinates.

Depends on D28011

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 5 - Move "feasible" result into ColumnBalanceData, and make reflow methods return ColumnBalanceData.

ColumnBalanceData is reset in the beginning of ReflowChildren(), so I
make ReflowChildren() return a fresh ColumnBalanceData so that it's
easier (at least for me) to understand the data is recomputed in
every reflow iteration.

Also, FindBestBalanceBSize() uses ColumnBalanceData as an input to begin
its column balancing iteration. Make the argument pass by value so that
the caller's copy won't be modified.

Depends on D28012

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 6 - Mark some nsColumnSetFrame methods "const".

Depends on D28013

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1545328 Part 7 - Fix a typo in FindBestBalanceBSize().

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ccd0940d635
Part 1 - Change two FindBestBalanceBSize()'s arguments to be passed by value. r=mats
https://hg.mozilla.org/integration/autoland/rev/ba82a40db675
Part 2 - Remove "virtual" keywords for methods that already have "override". r=mats
https://hg.mozilla.org/integration/autoland/rev/d4cf957cb4d3
Part 3 - Stop exposing ClampUsedColumnWidth() in the header. r=mats
https://hg.mozilla.org/integration/autoland/rev/31d11b8fca06
Part 4 - Replace "height" with "block-size" in comments. r=mats
https://hg.mozilla.org/integration/autoland/rev/93a076c63319
Part 5 - Move "feasible" result into ColumnBalanceData, and make reflow methods return ColumnBalanceData. r=mats
https://hg.mozilla.org/integration/autoland/rev/4120cfae1936
Part 6 - Mark some nsColumnSetFrame methods "const". r=mats
https://hg.mozilla.org/integration/autoland/rev/60b2b50f00a7
Part 7 - Fix a typo in FindBestBalanceBSize(). r=mats

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7ccd0940d635
https://hg.mozilla.org/mozilla-central/rev/ba82a40db675
https://hg.mozilla.org/mozilla-central/rev/d4cf957cb4d3
https://hg.mozilla.org/mozilla-central/rev/31d11b8fca06
https://hg.mozilla.org/mozilla-central/rev/93a076c63319
https://hg.mozilla.org/mozilla-central/rev/4120cfae1936
https://hg.mozilla.org/mozilla-central/rev/60b2b50f00a7