Some column set frame cleanup
Categories
(Core :: Layout: Columns, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(7 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
Some cleanup I'd like to do while figuring out how column reflow works.
|
Assignee | |
Comment 1•5 years ago
|
||
No code after FindBestBalanceBSize() is interested in
aUnboundedLastColumn and aRunWasFeasible, so they don't need to be
input/output arguments.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D28009
|
|
Assignee | |
Comment 3•5 years ago
|
||
The static function is used only in nsColumnSetFrame's implementation.
Depends on D28010
|
|
Assignee | |
Comment 4•5 years ago
|
||
I manually search "height" and replace it with "block-size" if the code
around it uses logical coordinates.
Depends on D28011
|
|
Assignee | |
Comment 5•5 years ago
|
||
ColumnBalanceData is reset in the beginning of ReflowChildren(), so I
make ReflowChildren() return a fresh ColumnBalanceData so that it's
easier (at least for me) to understand the data is recomputed in
every reflow iteration.
Also, FindBestBalanceBSize() uses ColumnBalanceData as an input to begin
its column balancing iteration. Make the argument pass by value so that
the caller's copy won't be modified.
Depends on D28012
|
|
Assignee | |
Comment 6•5 years ago
|
||
Depends on D28013
|
|
Assignee | |
Comment 7•5 years ago
|
||
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7ccd0940d635 Part 1 - Change two FindBestBalanceBSize()'s arguments to be passed by value. r=mats https://hg.mozilla.org/integration/autoland/rev/ba82a40db675 Part 2 - Remove "virtual" keywords for methods that already have "override". r=mats https://hg.mozilla.org/integration/autoland/rev/d4cf957cb4d3 Part 3 - Stop exposing ClampUsedColumnWidth() in the header. r=mats https://hg.mozilla.org/integration/autoland/rev/31d11b8fca06 Part 4 - Replace "height" with "block-size" in comments. r=mats https://hg.mozilla.org/integration/autoland/rev/93a076c63319 Part 5 - Move "feasible" result into ColumnBalanceData, and make reflow methods return ColumnBalanceData. r=mats https://hg.mozilla.org/integration/autoland/rev/4120cfae1936 Part 6 - Mark some nsColumnSetFrame methods "const". r=mats https://hg.mozilla.org/integration/autoland/rev/60b2b50f00a7 Part 7 - Fix a typo in FindBestBalanceBSize(). r=mats
|
||
Comment 9•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7ccd0940d635
https://hg.mozilla.org/mozilla-central/rev/ba82a40db675
https://hg.mozilla.org/mozilla-central/rev/d4cf957cb4d3
https://hg.mozilla.org/mozilla-central/rev/31d11b8fca06
https://hg.mozilla.org/mozilla-central/rev/93a076c63319
https://hg.mozilla.org/mozilla-central/rev/4120cfae1936
https://hg.mozilla.org/mozilla-central/rev/60b2b50f00a7
Description
•