Don't depend on sidebarOverlay for context menus

RESOLVED FIXED in mozilla1.1beta

Status

SeaMonkey
Sidebar
P3
normal
RESOLVED FIXED
16 years ago
14 years ago

People

(Reporter: Christopher Aillon (sabbatical, not receiving bugmail), Assigned: Christopher Aillon (sabbatical, not receiving bugmail))

Tracking

Trunk
mozilla1.1beta

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

context menus break if someone decides they don't want sidebarOverlay.xul since
we include the contentAreaContextOverlay from there.  We should remove the
hidden dependency.  Patch forthcoming...
Created attachment 89364 [details] [diff] [review]
Patch

Simply adds the contentAreaContextOverlay include into the files that were
including the sidebarOverlay.xul already and removes the dependency from the
sidebarOverlay.

Comment 2

16 years ago
Comment on attachment 89364 [details] [diff] [review]
Patch

r=sgehani

Could you list the tests conducted?
Attachment #89364 - Flags: review+
Sure.  I tested that context menus still work in:

- Navigator
- Navigator's Sidebar
- Navigator's Tabs
- Editor
- Editor's Sidebar
- Mail/News (both 3 pane and the other view)
- Mail/News (both 3 pane and the other view) Sidebar
- Address Book
- Address Book's Sidebar.

I verified that places that weren't directly affected still worked:
- DOM Inspector
- Chatzilla
- Venkman
- Bookmarks manager

In addition, no new JavaScript strict warnings or errors were introduced.
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.1beta
Blake, could you sr= this?

Comment 5

16 years ago
Comment on attachment 89364 [details] [diff] [review]
Patch

sr=jag
Attachment #89364 - Flags: superreview+
Landed on the trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.