154535 - Don't depend on sidebarOverlay for context menus

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect, P3)

Description

[Christopher Aillon (sabbatical, not receiving bugmail)]

context menus break if someone decides they don't want sidebarOverlay.xul since
we include the contentAreaContextOverlay from there.  We should remove the
hidden dependency.  Patch forthcoming...

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Patch

Simply adds the contentAreaContextOverlay include into the files that were
including the sidebarOverlay.xul already and removes the dependency from the
sidebarOverlay.

Comment 2

[Samir Gehani]

Comment on attachment 89364 [details] [diff] [review]
Patch

r=sgehani

Could you list the tests conducted?

Comment 3

[Christopher Aillon (sabbatical, not receiving bugmail)]

Sure.  I tested that context menus still work in:

- Navigator
- Navigator's Sidebar
- Navigator's Tabs
- Editor
- Editor's Sidebar
- Mail/News (both 3 pane and the other view)
- Mail/News (both 3 pane and the other view) Sidebar
- Address Book
- Address Book's Sidebar.

I verified that places that weren't directly affected still worked:
- DOM Inspector
- Chatzilla
- Venkman
- Bookmarks manager

In addition, no new JavaScript strict warnings or errors were introduced.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Blake, could you sr= this?

Comment 5

[jag (Peter Annema)]

Comment on attachment 89364 [details] [diff] [review]
Patch

sr=jag

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

Landed on the trunk