Closed Bug 1545355 Opened 2 years ago Closed 2 years ago

Authenticode GetBinaryOrgName not returning results from some Windows 7 builds

Categories

(Core :: mozglue, defect, P1)

Unspecified
Windows 7
defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Blocks 1 open bug)

Details

(Whiteboard: inj+)

Attachments

(1 file)

This is probably due to the sha256 changeover. This might be a bit tricky to figure out which builds use sha256 and which ones don't, and to use the appropriate code path.

The priority flag is not set for this bug.
:glandium, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Priority: -- → P3
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Priority: P3 → P1

On Windows 7, WinVerifyTrust fails unless the tag is uppercased. This patch
also adds a missing call to CryptCATAdminReleaseCatalogContext, the need for
which was poorly documented on MSDN.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bfc71363efc9
Uppercase hash tags before calling WinVerifyTrust on catalog files; r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

== Change summary for alert #20850 (as of Wed, 08 May 2019 08:39:09 GMT) ==

Improvements:

41% raptor-tp6m-instagram-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 opt 530.42 -> 310.50
36% raptor-tp6m-instagram-geckoview-cold android-hw-p2-8-0-android-aarch64 opt 847.29 -> 538.76
36% raptor-tp6m-facebook-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 opt 1,315.21 -> 848.00
31% raptor-tp6m-facebook-geckoview-cold android-hw-p2-8-0-android-aarch64 opt 1,583.44 -> 1,098.31

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=20850

This patch could not have affected android, as it is Windows-only.

Flags: needinfo?(fstrugariu)

Between May 7 and 8 we added new Android phone to our device pool, which temporarily messed up our perf tests.
Thus, these aren't real perf Improvements.

Sorry for the inconvenience..

Flags: needinfo?(fstrugariu)
You need to log in before you can comment on or make changes to this bug.