154538 - Activating Mailto link results in crash

Status: VERIFIED FIXED

(Camino Graveyard :: Page Layout, defect)

Description

[Chris Petersen]

Build: 2002-06-26-05
Platform: OS X 10.1.5
Expected Results: Clicking on Mailto: link should launch default mail application
What i got: Application crashes

Steps to reproduce:

1) Open test case and click on link
2) Application crashes

Comment 1

[Chris Petersen]

Attachment: stack trace

Comment 2

[Chris Petersen]

Worked in previous build (2002-06-25-05).

Comment 3

[saari (gone)]

->sdagley, regression, blocker

Comment 4

[Steve Dagley]

I'm investigating but the fickle finger of blame would currently be pointing at
bryner's change in v1.7 of ContentClickListener.mm

Comment 5

[Kathleen :Brade]

The following snippet fixes the crash for me but it doesn't do anything:
  nsCOMPtr<nsIURI> uri;
  if (NS_FAILED(NS_NewURI(getter_AddRefs(uri), href)))
    return NS_ERROR_FAILURE;

Comment 6

[Steve Dagley]

Attachment: Fixes regression from bryner's NSURLectomy

NS_NewURI fails to return a uri if we don't have a protcol handler for the href
passed in.  Just test for the nil uri rather than trying to get a service for
the scheme of a nil uri.

Comment 7

[Kathleen :Brade]

Comment on attachment 89448 [details] [diff] [review]
Fixes regression from bryner's NSURLectomy

r=brade
(altho I do wish we could just have the existing code be "if !uri {
escapedString... }" )

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 89448 [details] [diff] [review]
Fixes regression from bryner's NSURLectomy

r=bryner

Comment 9

[Steve Dagley]

fix just waiting for pinkerton to check it in (since I don't have check in privs
for mozilla/chimera)

Comment 10

[Mike Pinkerton (not reading bugmail)]

landed

Comment 11

[Chris Petersen]

Verified in the 2002-06-28-05 NB.