1545414 - taskcluster/taskgraph/util/perfile.py contains "test-verify-e10s" and "test-coverage-e10s"

Status: RESOLVED WORKSFORME

(Testing :: General, defect, P2)

Description

[Rob Wu [:robwu]]

Recently, I noticed that "-u test-verify-e10s" did not activate TV builds any more. TV is now associated with -u test-verify. I guess that this is part of the effort to drop "-e10s" in https://groups.google.com/d/msg/mozilla.dev.platform/BrMY8dqogAY/3kTfrIjOCQAJ

The following file still references "test-verify-e10s" and "test-coverage-e10s" though:
https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/taskcluster/taskgraph/util/perfile.py#74

The code was introduced in bug 1400895 and bug 1442790.

Comment 1

[Geoff Brown [:gbrown]]

'mach try fuzzy' and 'mach try chooser' both continue to work: test-verify jobs can be selected, and they run if selected.

Comment 2

[Geoff Brown [:gbrown]]

I also verified comment 0: -u test-verify successfully runs TV.

The code at https://searchfox.org/mozilla-central/rev/ee3905439acbf81e9c829ece0b46d09d2fa26c5c/taskcluster/taskgraph/util/perfile.py#74 works on the actual task name, which does still contain "e10s" -- it is still valid. The intent is to select test-verify/test-coverage on desktop, but to exclude Android, because Android does not run TV-gpu. The code is fragile, but it is using the only readily available data to make a slightly valuable improvement to the approximation; I'm inclined to leave it as it is.

Comment 3

[Geoff Brown [:gbrown]]

Please re-open if I am over-looking something.