1545426 - Latest release version on Socorro home page is showing as 66.0.3esr

Status: RESOLVED FIXED

(Socorro :: General, defect, P2)

Description

[Marcia Knous [:marcia]]

Visit https://crash-stats.mozilla.com/home/product/Firefox. Observe that the latest Firefox release version is showing as 66.0.3esr, when it really should be 66.0.3.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Huh. I'm not sure how to handle esr releases.

When you say "when it really should be", is there a specification that states that? Or are you saying you'd prefer it showed 66.0.3 and not 66.0.3esr because it affects something you do?

Seems to be the current esr should show up on that list because it's "supported" and something we should be looking at. But I don't know what people do with that page, so I don't know if my inclination towards correctness/completeness helps.

Comment 2

[Marcia Knous [:marcia]]

AFAIK the latest ESR release is 60.6.1, per what is shown here: https://www.mozilla.org/en-US/firefox/60.6.1/releasenotes/. So one data point is that there technically isn't a 66.0.3esr.

We don't really focus much on ESR in terms of stability, so IMO the main page should just show the current stable non ESR release for each product.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

We've got a bunch of crash reports for that version and that's how Socorro figures out what to show.

https://crash-stats.mozilla.com/search/?product=Firefox&version=66.0.3esr&date=%3E%3D2019-04-11T14%3A45%3A00.000Z&date=%3C2019-04-18T14%3A45%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

I'm not sure there's much I can do here given that we apparently have bad data.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Product details looks correct, https://product-details.mozilla.org/1.0/firefox_versions.json

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Sample report: https://crash-stats.mozilla.com/report/index/8974da23-0d95-4c13-8bb7-789360190417
Does this mean that somehow we updated someone on the ESR channel to 66.0.3?

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sorry I haven't gotten to this.

I think the issues here are two-fold:

1. The featured versions which show up in the navbar as well as on the product home page are susceptible to "junk data". It'd be nice if we could mitigate that.

2. ESR versions should never be considered a featured version.

I can fix the second item. I'll work on that next.

The first item needs thought. I don't know offhand how to fix it in a way that doesn't have us manually fiddling with the list of featured versions. We could go back to using product details again, but that was a bunch of code that only covers 2 of the 11 products we have. I'd rather we didn't piecemeal solve this since it creates a lot of maintenance burden. I think I'm going to push thinking about that off for now.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 4924: bug 1545426: don't include ESR versions in featured versions

Comment 8

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #4924: "bug 1545426: don't include ESR versions in featured versions" in 4809520.

Comment 9

[Will Kahn-Greene [:willkg] ET needinfo? me]

When I landed the code, I verified it in stage. We no longer see esr versions as featured anymore.

I just pushed this to prod. However, since we did a 66.0.4, the problem went away since 66.0.4 > 66.0.3esr before I deployed this fix to prod, so we can't verify it in prod.

Marking as FIXED.