1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1545440 - Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats

Now that they're not exposed to the web we can remove this special case.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24d0d307385d
Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats

Comment 3

[Razvan Maries]

backed out for perma failures on browser_parsable_css.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=24d0d307385d2cf5ce66854e40b92d7b15dc8428&selectedJob=241273827&searchStr=windows%2C10%2Cx64%2Cshippable%2Copt%2Cmochitests%2Ctest-windows10-64-shippable%2Fopt-mochitest-browser-chrome-e10s-5%2Cm%28bc5%29

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241281481&repo=autoland&lineNumber=2245

22:47:51 INFO - TEST-START | browser/base/content/test/static/browser_parsable_css.js
22:47:52 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | Got error message for chrome://browser/skin/places/tree-icons.css: Unknown pseudo-class or pseudo-element ‘-moz-tree-image’. Ruleset ignored due to bad selector. -
22:47:52 INFO - Stack trace:
22:47:52 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
22:47:52 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:262
22:47:52 INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:461
22:47:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
22:47:52 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
22:47:52 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
22:47:52 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘appearance’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Unknown property ‘user-select’. Declaration dropped." on resource://pdf.js/web/viewer.css because of whitelist item {"sourceName":"/web\/viewer\.css$/i","errorMessage":"/Unknown property.(appearance|user-select)/i","isFromDevTools":false,"used":true}
22:47:52 INFO - Ignored error "Expected media feature name but found ‘-moz-windows-default-theme’." on jar:file:///Z:/task_1555624784/build/application/firefox/browser/features/[e-mail]!/chrome/res/autocomplete-item.css because of whitelist item {"sourceName":"/\b(autocomplete-item|svg)\.css$/","errorMessage":"/Expected media feature name but found \u2018-moz./i","isFromDevTools":false,"used":true}
22:47:52 INFO - Not taking screenshot here: see the one that was previously logged

Backout: https://hg.mozilla.org/integration/autoland/rev/1af72fb16f17635bc192e6723063a7c88bd86dac

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Jorg, FYI, I don't think this should affect Thunderbird per my search:

https://searchfox.org/comm-central/search?q=%5B%5E%3A%5D%3A-moz-tree&case=false&regexp=true&path=

(The only hit in a CSS file is getting updated with this patch)

But ni? just in case there are other stylesheets or what not, so you're aware of this change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bb7a184f2c8
Don't allow to parse XUL tree pseudo-elements with a single colon. r=mats

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. I'll add Richard and Magnus to the bug.

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/1bb7a184f2c8