1545453 - Font Awesome icons should not be visible in Reader View

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[Nelson Pavlosky]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

1. Use Font Awesome SVG & JS icons on a page that is readable in Reader View
2. Open page in Reader View
3. Observe enormous icons that take up the full page width, harming readability

I filed a similar bug report for Font Awesome at https://github.com/FortAwesome/Font-Awesome/issues/14899

You can view a page that displays this problem at https://tagliala.github.io/fa14899.html

Actual results:

SVG icons appear in Reader View. This happens in the current stable macOS Mozilla Firefox 66.0.3, the latest nightly 68.0a1 (2019-04-17) (64-bit), and the current Android Firefox 66.0.2.

Expected results:

SVG icons are graphics that shouldn't show up at all in Reader View, neither Safari's reader view nor Chrome mobile's reader view displays them.

Comment 1

[Pablo]

Hello,

I was able to reproduce the issue with the link https://tagliala.github.io/fa14899.html on the latest nightly

Nightly 68.0a1 (2019-04-23) (64-bit) Windows10 64bit
Nightly 68.0a1 (2019-04-23) (64-bit) MacOS 10.13.6 64bit
Nightly 68.0a1 (64-bit) Ubuntu
Beta 67.0b13 (64-bit) MacOS 10.13.6 64bit

Comment 2

[:Gijs (he/him)]

Looks like we could key off aria-hidden in readability.

Comment 3

[Nelson Pavlosky]

This appears to have been fixed in Readability: https://github.com/mozilla/readability/issues/541

I no longer experience this bug in current versions of Firefox.

Comment 4

[:Gijs (he/him)]

(In reply to Nelson Pavlosky from comment #3)

This appears to have been fixed in Readability: https://github.com/mozilla/readability/issues/541

I no longer experience this bug in current versions of Firefox.

Thanks for the note! Yes, I believe this got fixed.