1545544 - Glean: Add a way to set branch/active experiment from ExperimentsDebugActivity

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Travis Long [:travis_]]

This is follow up work for 1543969.

Need to add a way to override the branch and active experiment via the ExperimentsDebugActivity in service-experiments.

Comment 1

[Travis Long [:travis_]]

I've hit a bit of a snag on this, so I'll push my Draft PR so you can look if needed. My first question is, what sort of validation do we need to do (if any) on what is supplied to the ExperimentsDebugActivity for the experiment id and branch name? My next question is, do we need to expose the functionality to be able to clear overrides through the ExperimentsDebugActivity?

Comment 2

[Travis Long [:travis_]]

Attachment: GitHub Pull Request

Comment 3

[Georg Fritzsche [:gfritzsche]]

(In reply to Travis Long from comment #1)

My first question is, what sort of validation do we need to do (if any) on what is supplied to the ExperimentsDebugActivity for the experiment id and branch name?

The id and branch name are just used locally for matching, so i don't think we need to apply any validation to the string.

My next question is, do we need to expose the functionality to be able to clear overrides through the ExperimentsDebugActivity?

Yes, that is a good point. If we don't provide it we can't turn the overrides off.
How about we just add one command that clears all possible overrides?